Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8273259: Character.getName doesn't follow Unicode spec for ideographs #5354

Closed
wants to merge 4 commits into from
Closed

8273259: Character.getName doesn't follow Unicode spec for ideographs #5354

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
294e3d7
8273259: Character.getName doesn't follow Unicode spec for ideographs
naotoj Sep 2, 2021
dc36e74
Refined wordings.
naotoj Sep 3, 2021
2debd0c
Reflecting the CSR review comment
naotoj Sep 10, 2021
0403429
Merge branch 'master' into JDK-8273259
naotoj Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 21 additions & 9 deletions src/java.base/share/classes/java/lang/Character.java
View file
Open in desktop
Expand Up @@ -11296,14 +11296,14 @@ public static char reverseBytes(char ch) {
}

/**
* Returns the Unicode name of the specified character
* Returns the name of the specified character
* {@code codePoint}, or null if the code point is
* {@link #UNASSIGNED unassigned}.
* <p>
* Note: if the specified character is not assigned a name by
* If the specified character is not assigned a name by
* the <i>UnicodeData</i> file (part of the Unicode Character
* Database maintained by the Unicode Consortium), the returned
* name is the same as the result of expression:
* name is the same as the result of the expression:
*
* <blockquote>{@code
* Character.UnicodeBlock.of(codePoint).toString().replace('_', ' ')
Expand All @@ -11312,9 +11312,15 @@ public static char reverseBytes(char ch) {
*
* }</blockquote>
*
* For the {@code codePoint}s in the <i>UnicodeData</i> file, the name
* returned by this method follows the naming scheme in the
* "Unicode Name Property" section of the Unicode Standard. For other
* code points, such as Hangul/Ideographs, The name generation rule above
* differs from the one defined in the Unicode Standard.
*
* @param codePoint the character (Unicode code point)
*
* @return the Unicode name of the specified character, or null if
* @return the name of the specified character, or null if
* the code point is unassigned.
*
* @throws IllegalArgumentException if the specified
Expand Down Expand Up @@ -11343,11 +11349,11 @@ public static String getName(int codePoint) {

/**
* Returns the code point value of the Unicode character specified by
* the given Unicode character name.
* the given character name.
* <p>
* Note: if a character is not assigned a name by the <i>UnicodeData</i>
* If a character is not assigned a name by the <i>UnicodeData</i>
* file (part of the Unicode Character Database maintained by the Unicode
* Consortium), its name is defined as the result of expression:
* Consortium), its name is defined as the result of the expression:
*
* <blockquote>{@code
* Character.UnicodeBlock.of(codePoint).toString().replace('_', ' ')
Expand All @@ -11359,12 +11365,18 @@ public static String getName(int codePoint) {
* The {@code name} matching is case insensitive, with any leading and
* trailing whitespace character removed.
*
* @param name the Unicode character name
* For the code points in the <i>UnicodeData</i> file, this method
* recognizes the name which conforms to the name defined in the
* "Unicode Name Property" section in the Unicode Standard. For other
* code points, this method recognizes the name generated with
* {@link #getName(int)} method.
*
* @param name the character name
*
* @return the code point value of the character specified by its name.
*
* @throws IllegalArgumentException if the specified {@code name}
* is not a valid Unicode character name.
* is not a valid character name.
* @throws NullPointerException if {@code name} is {@code null}
*
* @since 9
Expand Down