Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file #5543

Closed
wants to merge 5 commits into from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Sep 16, 2021

This commit appends the name of the JAR file to the exception message for when automatic module lists a non-existing provider class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5543/head:pull/5543
$ git checkout pull/5543

Update a local copy of the PR:
$ git checkout pull/5543
$ git pull https://git.openjdk.java.net/jdk pull/5543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5543

View PR using the GUI difftool:
$ git pr show -t 5543

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5543.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2021

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@sormuras The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 16, 2021
@sormuras sormuras marked this pull request as ready for review Sep 17, 2021
@openjdk openjdk bot added the rfr label Sep 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2021

Webrevs

dfuch
dfuch approved these changes Sep 23, 2021
Copy link
Member

@dfuch dfuch left a comment

The proposed change looks reasonable to me.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262944: Improve exception message when automatic module lists provider class not in JAR file

Reviewed-by: dfuchs, jvernee, alanb, lancea, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 253 new commits pushed to the master branch:

  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • c74726d: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
  • 2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
  • 8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
  • 986ee5d: 8274670: Improve version string handling in SA
  • df7b0c7: 8274715: Implement forEach in Collections.CopiesList
  • ... and 243 more: https://git.openjdk.java.net/jdk/compare/181292d48c989e3206354cea73bec015c13a986b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @JornVernee, @AlanBateman, @LanceAndersen, @mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 23, 2021
@sormuras
Copy link
Member Author

@sormuras sormuras commented Sep 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@sormuras
Your change (at version bb9762b) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor label Sep 23, 2021
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Thanks for the update. For completeness, you may want to add to the list of JBS issues listed at the top of AutomatcModulesTest and you probably should update its copyright year too.

Copy link
Member

@mlchung mlchung left a comment

Looks good to me.

@sormuras
Copy link
Member Author

@sormuras sormuras commented Oct 6, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@sormuras
Your change (at version f8b15c1) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Oct 6, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit c10de35.
Since your change was applied there have been 253 commits pushed to the master branch:

  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • c74726d: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
  • 2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
  • 8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
  • 986ee5d: 8274670: Improve version string handling in SA
  • df7b0c7: 8274715: Implement forEach in Collections.CopiesList
  • ... and 243 more: https://git.openjdk.java.net/jdk/compare/181292d48c989e3206354cea73bec015c13a986b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@AlanBateman @sormuras Pushed as commit c10de35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the JDK-8262944 branch Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
6 participants