-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc #5692
Conversation
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label nio |
@jaikiran |
/label add nio |
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@AlanBateman The |
Thank you Alan and Lance for the reviews. |
/integrate |
Could I please get a review for this trivial fix in the javadoc of WatchService#poll(long timeout, TimeUnit unit)?
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5692/head:pull/5692
$ git checkout pull/5692
Update a local copy of the PR:
$ git checkout pull/5692
$ git pull https://git.openjdk.java.net/jdk pull/5692/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5692
View PR using the GUI difftool:
$ git pr show -t 5692
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5692.diff