Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc #5692

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Sep 25, 2021

Could I please get a review for this trivial fix in the javadoc of WatchService#poll(long timeout, TimeUnit unit)?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5692/head:pull/5692
$ git checkout pull/5692

Update a local copy of the PR:
$ git checkout pull/5692
$ git pull https://git.openjdk.java.net/jdk pull/5692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5692

View PR using the GUI difftool:
$ git pr show -t 5692

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5692.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2021

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@jaikiran To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented Sep 25, 2021

/label nio

@openjdk openjdk bot added the nio label Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@jaikiran
The nio label was successfully added.

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Sep 25, 2021

/label add nio

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc

Reviewed-by: alanb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@AlanBateman The nio label was already applied.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 25, 2021

Webrevs

@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented Sep 25, 2021

Thank you Alan and Lance for the reviews.

@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented Sep 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

Going to push as commit 8c122af.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@jaikiran Pushed as commit 8c122af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8274314 branch Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
3 participants