8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful #5744

DamonFool · 2021-09-28T23:39:45Z

Hi all,

javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing on our non-GUI platforms.
So I guess it should be marked as headful.

Thanks.
Best regards,
Jie

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5744/head:pull/5744
$ git checkout pull/5744

Update a local copy of the PR:
$ git checkout pull/5744
$ git pull https://git.openjdk.java.net/jdk pull/5744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5744

View PR using the GUI difftool:
$ git pr show -t 5744

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5744.diff

…as headful

bridgekeeper · 2021-09-28T23:40:24Z

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-09-28T23:48:52Z

@DamonFool The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-09-28T23:54:04Z

Webrevs

00: Full (23d377a2)

mrserb · 2021-09-29T00:58:12Z

What exception is caused the test failure? This test was updated to be headless in the #5661

DamonFool · 2021-09-29T01:11:37Z

#5661

This test passed on our GUI platforms but failed without GUI.

STDERR:
java.lang.reflect.InvocationTargetException
        at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1371)
        at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1346)
        at java.desktop/javax.swing.SwingUtilities.invokeAndWait(SwingUtilities.java:1480)
        at bug6364882.main(bug6364882.java:83)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
        at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.AssertionError: paragraph doesn't have 6 rows of text
        at bug6364882.checkJustification(bug6364882.java:137)
        at bug6364882.lambda$main$0(bug6364882.java:87)
        at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
        at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
        at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
        at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
        at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
        at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
        at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
        at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
        at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
        at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
        at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

mrserb · 2021-09-29T01:19:03Z

This is a plain test failure, since exception is not a HeadlessException caused by some API required the desktop session.
headful key should not apply to it.

DamonFool · 2021-09-29T01:21:23Z

This is a plain test failure, since exception is not a HeadlessException caused by some API required the desktop session. headful key should not apply to it.

So any idea to fix it?
Thanks.

mrserb · 2021-09-29T01:33:43Z

It is possible that the test is too strict or this is a jdk bug. But I am not sure it is possible to investigate this issue based on the bug description in the JBS.
@aivanov-jdk please take a look.

DamonFool · 2021-09-29T01:40:24Z

It is possible that the test is too strict or this is a jdk bug. But I am not sure it is possible to investigate this issue based on the bug description in the JBS. @aivanov-jdk please take a look.

Can I problemlist this test?
Then we'll have enough time to investigate the root cause.
Thanks.

aivanov-jdk · 2021-09-29T11:44:49Z

@DamonFool could you attach the image to the bug report?

The image editorPane.png is automatically saved for analysis if the test fails, you should find in it the test artefacts along with the jtreg test log.

Could you elaborate on what our non-GUI platforms are? What is the OS? What is the CPU?

aivanov-jdk · 2021-09-29T11:51:25Z

It is possible that the test is too strict or this is a jdk bug. But I am not sure it is possible to investigate this issue based on the bug description in the JBS. @aivanov-jdk please take a look.

It could be too strict to the width of the fourth line of text. Yet it's not the case here. If the font size is tiny, it could be possible that the long text fits in less lines than four.

The image is required for analysis. And it looks the image isn't saved if assertion error is thrown.

aivanov-jdk · 2021-09-29T12:25:55Z

The image editorPane.png is automatically saved for analysis if the test fails, you should find in it the test artefacts along with the jtreg test log.

It is not saved on AssertionError — my bad.
I updated the test so that it saves the editorPane.png image if any exception occurs.

Could you please take the updated version of bug6364882.java from my JDK-8274465 branch or copy the bug6364882.java file? Then re-run the test and attach the image. Please also provide the console output of the test, it will contain the view dumps as well as the font used.

DamonFool · 2021-09-29T13:54:25Z

The image editorPane.png is automatically saved for analysis if the test fails, you should find in it the test artefacts along with the jtreg test log.

It is not saved on AssertionError — my bad. I updated the test so that it saves the editorPane.png image if any exception occurs.

Could you please take the updated version of bug6364882.java from my JDK-8274465 branch or copy the bug6364882.java file? Then re-run the test and attach the image. Please also provide the console output of the test, it will contain the view dumps as well as the font used.

Good!
Thanks @aivanov-jdk for your help.

My colleague @xpbob would like to follow this issue.
We agree with you that the test shouldn't be headful.

Since it's near our National Day, many of us would go on vacation.
He may reply your questions either tonight or the day after tomorrow.
Thanks.

aivanov-jdk · 2021-09-29T16:48:25Z

There are relevant comments raised by @prrace in #5661.

For convenience, I'm posting them here:

@prrace said:
I've looked at the test a tad more and two comments

if it fails, it dumps an image. You can provide that image
It is sensitive to the actual font. If your default font for whatever reason is of a size thatonemore or one less word will fit on a line, then it will fail. This does look like a test problem to me.

@aivanov-jdk replied:

Thank you, @prrace, for your comments.

Unfortunately, it doesn't save the image if an exception is thrown. I overlooked this fact.
I agree I should've made it more flexible to accommodate for possible font size differences.

I'll fix these issues and create my own PR for JDK-8274465.

aivanov-jdk · 2021-09-29T19:53:12Z

@DamonFool, I have created a new PR #5761 which should fix the test failure.

Could you please test whether it fixes the failure?

Please, also perform the previous experiment first and attach the image of the failure to JBS.

DamonFool · 2021-09-29T23:16:14Z

Will discuss it in #5761 .
So close this one.

DamonFool · 2021-09-30T06:09:59Z

@DamonFool, I have created a new PR #5761 which should fix the test failure.

Could you please test whether it fixes the failure?

Please, also perform the previous experiment first and attach the image of the failure to JBS.

The png has been uploaded in the JBS.
Now I am testing your new patch.

8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java …

23d377a

…as headful

openjdk bot added the rfr Pull request is ready for review label Sep 28, 2021

openjdk bot added the client client-libs-dev@openjdk.org label Sep 28, 2021

aivanov-jdk mentioned this pull request Sep 29, 2021

8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java #5661

Closed

3 tasks

aivanov-jdk mentioned this pull request Sep 29, 2021

8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures #5761

Closed

3 tasks

DamonFool closed this Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful #5744

8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful #5744

DamonFool commented Sep 28, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 28, 2021

openjdk bot commented Sep 28, 2021

mlbridge bot commented Sep 28, 2021

mrserb commented Sep 29, 2021

DamonFool commented Sep 29, 2021

mrserb commented Sep 29, 2021

DamonFool commented Sep 29, 2021

mrserb commented Sep 29, 2021

DamonFool commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021 •

edited

Loading

DamonFool commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

DamonFool commented Sep 29, 2021

DamonFool commented Sep 30, 2021

8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful #5744

8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful #5744

Conversation

DamonFool commented Sep 28, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewing

bridgekeeper bot commented Sep 28, 2021

openjdk bot commented Sep 28, 2021

mlbridge bot commented Sep 28, 2021

Webrevs

mrserb commented Sep 29, 2021

DamonFool commented Sep 29, 2021

mrserb commented Sep 29, 2021

DamonFool commented Sep 29, 2021

mrserb commented Sep 29, 2021

DamonFool commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021 • edited Loading

DamonFool commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

aivanov-jdk commented Sep 29, 2021

DamonFool commented Sep 29, 2021

DamonFool commented Sep 30, 2021

DamonFool commented Sep 28, 2021 •

edited by openjdk bot

Loading

aivanov-jdk commented Sep 29, 2021 •

edited

Loading