-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java #5661
Conversation
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that an updated test still fail before JDK-6364882
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Correct. I forgot to add this statement. The updated test fails with builds of JDK 6 until JDK-6364882 is fixed, that is the test fails when run with 6-b75 and passes when run with 6-b76. In this way the test and PR are related to JDK-8239502 and #5661 correspondingly. |
/integrate |
Going to push as commit 67e52a3.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk Pushed as commit 67e52a3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test looks headless. |
I've looked at the test a tad more and two comments
|
Thank you, @prrace, for your comments.
I'll fix these issues and create my own PR for JDK-8274465. |
"Unfortunately, it doesn't save the image if an exception is thrown. I overlooked this fact." oops :-) |
The test is being moved from the closed to open.
I updated the
bug6364882.java
test so that it's headless now. If it fails, the image of theeditorPane
is saved for analysis. I also added more asserts which verify:• the first three lines are aligned to the right edge;
• the fourth line isn't justified and its width is less than 3/4 of the width;
• the fifth and sixth lines have width less than that of the fourth line and have the same width.
There's an option to show the UI for visual inspection as well as to save the image even if the test passes; use
-show
and/or-save
parameters to the test correspondingly.[1] JDK-6364882: Last line of a paragraph should not be justified
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5661/head:pull/5661
$ git checkout pull/5661
Update a local copy of the PR:
$ git checkout pull/5661
$ git pull https://git.openjdk.java.net/jdk pull/5661/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5661
View PR using the GUI difftool:
$ git pr show -t 5661
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5661.diff