JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #6025

frkator · 2021-10-20T00:04:08Z

cc @ctornqvi

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11

Reviewers

Brian Burkhalter (@bplb - Reviewer) ⚠️ Review applies to 931a9ea
Mark Sheppard (@msheppar - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6025/head:pull/6025
$ git checkout pull/6025

Update a local copy of the PR:
$ git checkout pull/6025
$ git pull https://git.openjdk.java.net/jdk pull/6025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6025

View PR using the GUI difftool:
$ git pr show -t 6025

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6025.diff

frkator · 2021-10-20T00:04:21Z

/integrate

bridgekeeper · 2021-10-20T00:04:36Z

👋 Welcome back isipka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-10-20T00:06:01Z

@frkator Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

openjdk · 2021-10-20T00:06:42Z

@frkator To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

build
client
compiler
core-libs
hotspot
hotspot-compiler
hotspot-gc
hotspot-jfr
hotspot-runtime
i18n
ide-support
javadoc
jdk
jmx
kulla
net
nio
security
serviceability
shenandoah

frkator · 2021-10-20T12:37:53Z

/label core-libs

Adding the test java/io/File/createTempFile/SpecialTempFile.java to problem list for windows 11 platform as per ticket. The tier2 test group ignores the said test when ran on Windows 11 Enteprise Node but does get ran on Windows 2016 node. Details in ticket comment.

openjdk · 2021-10-20T12:38:23Z

@frkator The label corelibs is not a valid label. These labels are valid:

serviceability
hotspot
hotspot-compiler
ide-support
kulla
i18n
shenandoah
jdk
javadoc
security
hotspot-runtime
jmx
build
nio
client
core-libs
compiler
net
hotspot-gc
hotspot-jfr

iignatev · 2021-10-20T17:13:45Z

/label core-libs

openjdk · 2021-10-20T17:14:47Z

@iignatev
The core-libs label was successfully added.

openjdk · 2021-10-20T17:17:20Z

@frkator This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11

Reviewed-by: bpb, msheppar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

d6d82f5: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
a1ec4f9: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
4c3491b: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
c0cda1d: 8273026: Slow LoginContext.login() on multi threading application
15fd8a3: 8276102: JDK-8245095 integration reverted JDK-8247980
e89b2c0: 8276086: Increase size of metaspace mappings
24cf480: 8276047: G1: refactor G1CardSetArrayLocker
e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
... and 42 more: https://git.openjdk.java.net/jdk/compare/574f8903ee1f74bdf7154d670d96c36d94b38b4d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iignatev, @bplb, @msheppar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2021-10-20T17:23:20Z

Webrevs

iignatev

as it has been discussed internally, jtreg doesn’t recognize $os-$arch-$version pattern in problem list (but understands $os-$version) so for the test to be excluded only on windows 11, you should use windows-11

iignatev · 2021-10-26T20:59:45Z

And now you use an incorrect bug id in the problem list, it should be 8274122

bplb · 2021-10-26T21:05:11Z

Oops! Thanks @iignatev !

msheppar · 2021-10-28T18:21:29Z

as per comment from Igor above, the bug id in the problemlist is incorrect, and it should be 8274122
you have used the bugid for this problemlist update

frkator · 2021-10-28T22:05:20Z

Thank you @iignatev @bplb @msheppar. Problem listing the test works as expected details in ticket comment.

frkator · 2021-10-28T22:05:25Z

/integrate

openjdk · 2021-10-28T22:06:35Z

@frkator Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

frkator · 2021-10-29T10:38:08Z

as per comment from Igor above, the bug id in the problemlist is incorrect, and it should be 8274122 you have used the bugid for this problemlist update

@msheppar the bug id has been updated

msheppar · 2021-10-29T10:46:08Z

bugid in title should be 8275650: i.e. the bugid for problemlist update

frkator · 2021-10-29T15:29:46Z

/integrate

openjdk · 2021-10-29T15:31:27Z

@frkator
Your change (at version d29620d) is now ready to be sponsored by a Committer.

msheppar · 2021-11-03T19:28:50Z

/sponsor

openjdk · 2021-11-03T19:30:24Z

Going to push as commit 32895ac.
Since your change was applied there have been 103 commits pushed to the master branch:

c7f070f: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output"
684edbb: 8273922: (fs) UserDefinedFileAttributeView doesn't handle file names that are just under the MAX_PATH limit (win)
7115892: 8276401: Use blessed modifier order in java.net.http
0ef8cbe: 8276385: Re-run blessed-modifier-order script on java.desktop and jdk.accessibility
724bf3b: 8275604: Zero: Reformat opclabels_data
61cb4bc: 8276036: The value of full_count in the message of insufficient codecache is wrong
8731846: 8276556: ProblemList java/nio/channels/FileChannel/LargeGatheringWrite.java on windows-x64
be1ca2b: 8276298: G1: Remove unused G1SegmentedArrayBufferList::add
a316c06: 8275730: Relax memory constraint on MultiThreadedRefCounter
6150633: 8276348: Use blessed modifier order in java.base
... and 93 more: https://git.openjdk.java.net/jdk/compare/574f8903ee1f74bdf7154d670d96c36d94b38b4d...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-11-03T19:30:37Z

@msheppar @frkator Pushed as commit 32895ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

iignatev · 2021-11-03T22:12:29Z

That doesn’t seem right as jtreg expects <os>-<version> not <os><version>

frkator · 2021-11-03T23:11:36Z

That doesn’t seem right as jtreg expects <os>-<version> not <os><version>

It has been tested, details in ticket comment.

iignatev · 2021-11-04T01:34:01Z

I’m sorry @frkator but there is nothing in the ticket.

dholmes-ora · 2021-11-04T02:03:01Z

@iignatev the comment is confidential as it refers to internal testing infrastructure.
@frkator be mindful of what parts of the JBS issue are public and which are not.

iignatev · 2021-11-04T02:14:09Z

Thanks for the clarification, David. I guess my recollection of jtreg code isn’t as good as I thought, and - isn’t mandatory, though this means there is a (theoretically possible) ambiguity, e.g. {os=windows; version=11} vs {os=windows1; version=1}

frkator · 2021-11-04T16:23:10Z

@iignatev the comment is confidential as it refers to internal testing infrastructure. @frkator be mindful of what parts of the JBS issue are public and which are not.

@dholmes-ora you mean I should have stated that the links are in confidential part of the ticket?

iignatev · 2021-11-04T16:38:49Z

I guess the proper course of actions would be not to mention any confidential comments/information (including their existence) in open communication at all, and instead provided open community with the enough publicly available information so they can understand the bug, patch, testing, …, in this particular case it would mean describing the testing w/o providing any details about oracle resources

frkator changed the title ~~8274122: added to problem list~~ 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 Oct 20, 2021

frkator changed the title ~~8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11~~ 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Oct 20, 2021

openjdk bot added the rfr Pull request is ready for review label Oct 20, 2021

openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 20, 2021

iignatev approved these changes Oct 20, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2021

iignatev suggested changes Oct 22, 2021

View reviewed changes

openjdk bot removed the ready Pull request is ready to be integrated label Oct 22, 2021

frkator added 2 commits October 26, 2021 16:52

8274122: added to problem list

f0e3587

fixed OS identifier

931a9ea

frkator force-pushed the JDK-8274122-problemlist-special-tempfile branch from 55b0228 to 931a9ea Compare October 26, 2021 19:43

openjdk bot removed the rfr Pull request is ready for review label Oct 26, 2021

bplb approved these changes Oct 26, 2021

View reviewed changes

changing os id

97d000a

openjdk bot added the rfr Pull request is ready for review label Oct 28, 2021

frkator changed the title ~~8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11~~ 8274122: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Oct 28, 2021

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2021

removed file added by accident

d29620d

frkator changed the title ~~8274122: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11~~ JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Oct 29, 2021

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2021

msheppar approved these changes Oct 29, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 29, 2021

openjdk bot closed this Nov 3, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 3, 2021

frkator deleted the JDK-8274122-problemlist-special-tempfile branch November 10, 2021 13:29

JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #6025

JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #6025

frkator commented Oct 20, 2021 •

edited by openjdk bot

frkator commented Oct 20, 2021

bridgekeeper bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

frkator commented Oct 20, 2021 •

edited

openjdk bot commented Oct 20, 2021

iignatev commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021 •

edited

mlbridge bot commented Oct 20, 2021 •

edited

iignatev left a comment •

edited

iignatev commented Oct 26, 2021

bplb commented Oct 26, 2021

msheppar commented Oct 28, 2021

frkator commented Oct 28, 2021

frkator commented Oct 28, 2021

openjdk bot commented Oct 28, 2021

frkator commented Oct 29, 2021 •

edited

msheppar commented Oct 29, 2021

frkator commented Oct 29, 2021

openjdk bot commented Oct 29, 2021

msheppar commented Nov 3, 2021

openjdk bot commented Nov 3, 2021

openjdk bot commented Nov 3, 2021

iignatev commented Nov 3, 2021

frkator commented Nov 3, 2021

iignatev commented Nov 4, 2021

dholmes-ora commented Nov 4, 2021

iignatev commented Nov 4, 2021

frkator commented Nov 4, 2021

iignatev commented Nov 4, 2021

JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #6025

JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #6025

Conversation

frkator commented Oct 20, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

frkator commented Oct 20, 2021

bridgekeeper bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

frkator commented Oct 20, 2021 • edited

openjdk bot commented Oct 20, 2021

iignatev commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021 • edited

mlbridge bot commented Oct 20, 2021 • edited

Webrevs

iignatev left a comment • edited

Choose a reason for hiding this comment

iignatev commented Oct 26, 2021

bplb commented Oct 26, 2021

msheppar commented Oct 28, 2021

frkator commented Oct 28, 2021

frkator commented Oct 28, 2021

openjdk bot commented Oct 28, 2021

frkator commented Oct 29, 2021 • edited

msheppar commented Oct 29, 2021

frkator commented Oct 29, 2021

openjdk bot commented Oct 29, 2021

msheppar commented Nov 3, 2021

openjdk bot commented Nov 3, 2021

openjdk bot commented Nov 3, 2021

iignatev commented Nov 3, 2021

frkator commented Nov 3, 2021

iignatev commented Nov 4, 2021

dholmes-ora commented Nov 4, 2021

iignatev commented Nov 4, 2021

frkator commented Nov 4, 2021

iignatev commented Nov 4, 2021

frkator commented Oct 20, 2021 •

edited by openjdk bot

frkator commented Oct 20, 2021 •

edited

openjdk bot commented Oct 20, 2021 •

edited

mlbridge bot commented Oct 20, 2021 •

edited

iignatev left a comment •

edited

frkator commented Oct 29, 2021 •

edited