New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException #6536
Conversation
… RuntimeException
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I agree this is trivial
@fmatte1 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iklam, @chhagedorn) but any other Committer may sponsor as well.
|
Thanks, for the review. |
/integrate |
/sponsor |
Going to push as commit f0136ec.
Your commit was automatically rebased without conflicts. |
@chhagedorn @fmatte1 Pushed as commit f0136ec. |
During the review of #5231 (review)
It was suggested by @iklam in the test case Runtime exception is not required for the reason TouchedMethodsDCmd is always enabled as long as the current JVM has INCLUDE_SERVICES is true.
Igor has agreed to capture this in separate RFE (current) to handle this scenario.
This is trivial, please review.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6536/head:pull/6536
$ git checkout pull/6536
Update a local copy of the PR:
$ git checkout pull/6536
$ git pull https://git.openjdk.java.net/jdk pull/6536/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6536
View PR using the GUI difftool:
$ git pr show -t 6536
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6536.diff