8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size

[tkiriyama]

I would like to fix the bug reported in JDK-8277866.
There is a typo in test/hotspot/jtreg/gc/epsilon/TestMemoryMXBeans.java as suggested in the issue.
The second test case is expected to run with -Xms in addition to -Xmx option. However, -Xmx option appears twice in the test.
This typo causes a failure of the test, and after fixing this typo, the test successfully passed.
Although ProblemList contains TestMemoryMXBeans.java, this typo should be fixed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6574/head:pull/6574
$ git checkout pull/6574

Update a local copy of the PR:
$ git checkout pull/6574
$ git pull https://git.openjdk.java.net/jdk pull/6574/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6574

View PR using the GUI difftool:
$ git pr show -t 6574

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6574.diff

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (514d65e4)

[tschatzl]

Lgtm. Thanks for spotting this.

[openjdk]

⚠️ @tkiriyama the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8277866
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size

Reviewed-by: tschatzl, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• 8d7958e: 8277981: String Deduplication table is never cleaned up due to bad dead_factor_for_cleanup
• bc6dce1: 8277736: G1: Allow forced evacuation failure of first N regions in collection set
• 0c29ee5: 8274319: Replace usages of Collections.sort with List.sort call in jdk.jfr
• f505396: 8277459: Add jwebserver tool
• 84aa0a1: 8278047: Few javax/imageio test regressed after JDK-8262297 fix
• fde0b95: 8277861: Terminally deprecate Thread.stop
• 70d5dff: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
• 349328c: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
• c733193: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
• da2be99: 8277026: Remove blank lines remaining from snippet markup
• ... and 46 more: https://git.openjdk.java.net/jdk/compare/040b2c52d3e82048630fbd45a7db48a5e65204b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

Yes, that's a correct fix. Thanks!

[tkiriyama]

Thank you for your reviews. I hope this change is integrated.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version 514d65e) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 37ff7f3.
Since your change was applied there have been 56 commits pushed to the master branch:

• 8d7958e: 8277981: String Deduplication table is never cleaned up due to bad dead_factor_for_cleanup
• bc6dce1: 8277736: G1: Allow forced evacuation failure of first N regions in collection set
• 0c29ee5: 8274319: Replace usages of Collections.sort with List.sort call in jdk.jfr
• f505396: 8277459: Add jwebserver tool
• 84aa0a1: 8278047: Few javax/imageio test regressed after JDK-8262297 fix
• fde0b95: 8277861: Terminally deprecate Thread.stop
• 70d5dff: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
• 349328c: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
• c733193: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
• da2be99: 8277026: Remove blank lines remaining from snippet markup
• ... and 46 more: https://git.openjdk.java.net/jdk/compare/040b2c52d3e82048630fbd45a7db48a5e65204b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @tkiriyama Pushed as commit 37ff7f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[turbanoff]

BTW, I found couple more tests which set Xmx twice:

1. TestGCLockerWithSerial
2. LoadUnloadModuleStress

[shipilev]

BTW, I found couple more tests which set Xmx twice:

1. `TestGCLockerWithSerial`

2. `LoadUnloadModuleStress`

Good spot! I fixed those two as well, see related PRs.