Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs #7030

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jan 11, 2022

Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener: ‘Constucts’ → ‘Constructs’.
Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the list’.

I also organised the imports which replaced all wildcard imports with specific class imports.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7030/head:pull/7030
$ git checkout pull/7030

Update a local copy of the PR:
$ git checkout pull/7030
$ git pull https://git.openjdk.java.net/jdk pull/7030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7030

View PR using the GUI difftool:
$ git pr show -t 7030

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7030.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2022
@openjdk
Copy link

openjdk bot commented Jan 11, 2022

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 129 new commits pushed to the master branch:

  • d1efb0c: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure
  • 6179e13: 8266410: jdk/jfr/javaagent/TestLoadedAgent.java failed with "Mismatch in TestEvent count"
  • 5523dde: 8279641: Create manual JTReg tests for Swing accessibility
  • dac15ef: 8280182: HotSpot Style Guide has stale link to chromium style guide
  • 84fa0d8: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel
  • 610a129: 8268831: Improve javadoc tool handling of streams.
  • e20c6bf: 8280189: JFR: TestPrintXML should print mismatching XML
  • b20b11c: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '' in paths
  • 9611431: 8279936: Change shared code to use os:: system API's
  • cc2f474: 8280024: Parallel: Remove unnecessary region resizing methods in PSCardTable
  • ... and 119 more: https://git.openjdk.java.net/jdk/compare/4471e95174a89d83794ed894c2a1bb3fc9def74d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 19, 2022
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2022

Going to push as commit dae2226.
Since your change was applied there have been 211 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2022
@openjdk openjdk bot closed this Jan 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2022
@openjdk
Copy link

openjdk bot commented Jan 24, 2022

@aivanov-jdk Pushed as commit dae2226.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8279795-BasicFileChooserUI-typo branch February 21, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants