-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon #740
8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon #740
Conversation
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
@vicente-romero-oracle The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove core-libs,hotspot-runtime,javadoc,kulla,serviceability |
@vicente-romero-oracle The The The The |
Looks good to me. |
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@vicente-romero-oracle Pushed as commit 1da28de. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
I pushed the fixes for JDK-8246774 and JDK-8253455 too soon as the JEP is still not targeted so this fix will delta apply them until the JEP is finally targeted,
Sorry for the noise,
Vicente
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/740/head:pull/740
$ git checkout pull/740