Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon #740

Conversation

@vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Oct 19, 2020

Hi,

I pushed the fixes for JDK-8246774 and JDK-8253455 too soon as the JEP is still not targeted so this fix will delta apply them until the JEP is finally targeted,

Sorry for the noise,
Vicente


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) (2/2 running) ✔️ (2/2 passed)
Test (tier1) (6/9 running) (8/9 running)

Issue

  • JDK-8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/740/head:pull/740
$ git checkout pull/740

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2020

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@vicente-romero-oracle The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-runtime
  • javadoc
  • kulla
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@vicente-romero-oracle
Copy link
Contributor Author

@vicente-romero-oracle vicente-romero-oracle commented Oct 19, 2020

/label remove core-libs,hotspot-runtime,javadoc,kulla,serviceability

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@vicente-romero-oracle
The core-libs label was successfully removed.

The hotspot-runtime label was successfully removed.

The javadoc label was successfully removed.

The kulla label was successfully removed.

The serviceability label was successfully removed.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2020

Webrevs

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Oct 19, 2020

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2020
@vicente-romero-oracle
Copy link
Contributor Author

@vicente-romero-oracle vicente-romero-oracle commented Oct 19, 2020

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@vicente-romero-oracle Pushed as commit 1da28de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants