-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10 #8026
Conversation
Reviewed-by: naoto, kizune
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
@alisenchung The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Since this is identical to the original fix, I would expect the same Tier2 test failure as reported in JDK-8283804. |
I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the bug id in the test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming all tests passed.
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@alisenchung |
/sponsor |
Going to push as commit 38df570.
Your commit was automatically rebased without conflicts. |
@naotoj @alisenchung Pushed as commit 38df570. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
redo of 8280400
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8026/head:pull/8026
$ git checkout pull/8026
Update a local copy of the PR:
$ git checkout pull/8026
$ git pull https://git.openjdk.java.net/jdk pull/8026/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8026
View PR using the GUI difftool:
$ git pr show -t 8026
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8026.diff