Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10 #8026

Closed
wants to merge 3 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Mar 30, 2022

redo of 8280400


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8026/head:pull/8026
$ git checkout pull/8026

Update a local copy of the PR:
$ git checkout pull/8026
$ git pull https://git.openjdk.java.net/jdk pull/8026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8026

View PR using the GUI difftool:
$ git pr show -t 8026

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8026.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@alisenchung The following labels will be automatically applied to this pull request:

  • client
  • compiler
  • core-libs
  • i18n
  • javadoc
  • jmx
  • kulla
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc security serviceability jmx client core-libs compiler net kulla i18n labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Mar 30, 2022

Since this is identical to the original fix, I would expect the same Tier2 test failure as reported in JDK-8283804.

@naotoj
Copy link
Member

naotoj commented Mar 30, 2022

I believe src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties and test/jdk/sun/text/resources/LocaleData have to be adjusted according to the l10n changes.

Copy link
Member

@naotoj naotoj left a comment

Please add the bug id in the test case.

naotoj
naotoj approved these changes Mar 31, 2022
Copy link
Member

@naotoj naotoj left a comment

LGTM, assuming all tests passed.

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • ad83ec7: 8283422: Create a new test for JDK-8254790
  • 6ebf845: 8283566: G1: Improve G1BarrierSet::enqueue performance
  • d276da5: 8281469: aarch64: Improve interpreter stack banging
  • a41550b: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException
  • 207b099: 8283890: Changes in CFG file format break C1Visualizer
  • 49fcc7a: 8283013: Simplify Arguments::parse_argument()
  • 73cb922: 8284026: Use unmodifiable collections where practical
  • 77a205a: 8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile
  • 64025b0: 8283901: Introduce "make doctor" to diagnose build environment problems
  • 5740a3b: 8280193: summary javadoc for java.awt.GraphicsEnvironment#preferProportionalFonts broken
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/fe670ff403b259f94bb50e1aa1e0155b71fc6642...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 31, 2022
@alisenchung
Copy link
Contributor Author

alisenchung commented Mar 31, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@alisenchung
Your change (at version fa89c71) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 31, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

Going to push as commit 38df570.
Since your change was applied there have been 59 commits pushed to the master branch:

  • ad83ec7: 8283422: Create a new test for JDK-8254790
  • 6ebf845: 8283566: G1: Improve G1BarrierSet::enqueue performance
  • d276da5: 8281469: aarch64: Improve interpreter stack banging
  • a41550b: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException
  • 207b099: 8283890: Changes in CFG file format break C1Visualizer
  • 49fcc7a: 8283013: Simplify Arguments::parse_argument()
  • 73cb922: 8284026: Use unmodifiable collections where practical
  • 77a205a: 8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile
  • 64025b0: 8283901: Introduce "make doctor" to diagnose build environment problems
  • 5740a3b: 8280193: summary javadoc for java.awt.GraphicsEnvironment#preferProportionalFonts broken
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/fe670ff403b259f94bb50e1aa1e0155b71fc6642...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 31, 2022
@openjdk openjdk bot closed this Mar 31, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@naotoj @alisenchung Pushed as commit 38df570.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client compiler core-libs i18n integrated javadoc jmx kulla net security serviceability
3 participants