-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284767: Create an automated test for JDK-4422535 #8220
Conversation
👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into |
Webrevs
|
test/jdk/javax/accessibility/4422535/SetCurrentAccessibleValueTest.java
Outdated
Show resolved
Hide resolved
…ponents being tested.
@alisenchung Can you please review the changes after incorporating the earlier feedback ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, get rid of the useless directory
Hi! Can someone please take a look at this PR and provide their valuable feedback ? |
1 similar comment
Hi! Can someone please take a look at this PR and provide their valuable feedback ? |
/integrate |
@srmandal This pull request has not yet been marked as ready for integration. |
Hi! Can someone please take a look at this PR and provide their valuable feedback and approval ? |
test/jdk/javax/accessibility/SetCurrentAccessibleValueTest.java
Outdated
Show resolved
Hide resolved
Hi! Can someone please take a look at this PR and provide their valuable feedback and approval? |
1 similar comment
Hi! Can someone please take a look at this PR and provide their valuable feedback and approval? |
@srmandal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 314 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Can someone sponsor this PR? |
/sponsor |
Going to push as commit 5ae4320.
Your commit was automatically rebased without conflicts. |
Create an automated test for JDK-4422535
AccessibleValue implementation only accept Integers
The AccessibleValue implementations of the following components:
java.awt.Scrollbar
javax.swing.AbstractButton
javax.swing.JInternalFrame
javax.swing.JSplitPane
javax.swing.JScrollBar
javax.swing.JProgressBar
javax.swing.JSlider
require the argument to setCurrentAccessibleValue(Number) to be an Integer, else they completely ignore it - it returns a false indicating that the value has not been set by the return value, but they cannot know the reason for that).
The test verifies that for each of the above components, the AccessibleValue is set when it is set to a Number (Float, Double, long etc) and not just for an Integer.
his review is for migrating tests from a closed test suite to open.
Testing:
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/8220/head:pull/8220
$ git checkout pull/8220
Update a local copy of the PR:
$ git checkout pull/8220
$ git pull https://git.openjdk.org/jdk pull/8220/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8220
View PR using the GUI difftool:
$ git pr show -t 8220
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/8220.diff