Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284767: Create an automated test for JDK-4422535 #8220

Closed
wants to merge 6 commits into from

Conversation

srmandal
Copy link

@srmandal srmandal commented Apr 13, 2022

Create an automated test for JDK-4422535
AccessibleValue implementation only accept Integers
The AccessibleValue implementations of the following components:

java.awt.Scrollbar
javax.swing.AbstractButton
javax.swing.JInternalFrame
javax.swing.JSplitPane
javax.swing.JScrollBar
javax.swing.JProgressBar
javax.swing.JSlider

require the argument to setCurrentAccessibleValue(Number) to be an Integer, else they completely ignore it - it returns a false indicating that the value has not been set by the return value, but they cannot know the reason for that).

The test verifies that for each of the above components, the AccessibleValue is set when it is set to a Number (Float, Double, long etc) and not just for an Integer.

his review is for migrating tests from a closed test suite to open.

Testing:
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284767: Create an automated test for JDK-4422535

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/8220/head:pull/8220
$ git checkout pull/8220

Update a local copy of the PR:
$ git checkout pull/8220
$ git pull https://git.openjdk.org/jdk pull/8220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8220

View PR using the GUI difftool:
$ git pr show -t 8220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/8220.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2022

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@srmandal The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 13, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 13, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Webrevs

@srmandal
Copy link
Author

srmandal commented May 2, 2022

@alisenchung Can you please review the changes after incorporating the earlier feedback ?

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, get rid of the useless directory

@srmandal
Copy link
Author

srmandal commented Jun 1, 2022

Hi! Can someone please take a look at this PR and provide their valuable feedback ?

1 similar comment
@srmandal
Copy link
Author

srmandal commented Jun 9, 2022

Hi! Can someone please take a look at this PR and provide their valuable feedback ?

@srmandal
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@srmandal This pull request has not yet been marked as ready for integration.

@srmandal
Copy link
Author

Hi! Can someone please take a look at this PR and provide their valuable feedback and approval ?

@srmandal
Copy link
Author

srmandal commented Jul 2, 2022

Hi! Can someone please take a look at this PR and provide their valuable feedback and approval?

1 similar comment
@srmandal
Copy link
Author

Hi! Can someone please take a look at this PR and provide their valuable feedback and approval?

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284767: Create an automated test for JDK-4422535

Reviewed-by: prr, achung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 314 new commits pushed to the master branch:

  • 0184f46: 8289919: [test] LoadLibraryUnloadTest.java failed with "Failed to unload native library"
  • cca91f7: 8290327: Remove java/lang/reflect/callerCache/ReflectionCallerCacheTest.java from ProblemList-Xcomp.txt
  • b4e2ce0: 8290366: Remove unused during_conc_mark parameter in HeapRegion::note_self_forwarding_removal_start
  • f3abb82: 8268312: Compilation error with nested generic functional interface
  • 92deab5: 8028265: Add legacy tz tests to OpenJDK
  • 70fce07: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 757a742: 8290177: Improve documentation in G1MMUTracker
  • 890bced: 8290264: java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"
  • 3ad3950: Merge
  • fd89ab8: 8288112: C2: Error: ShouldNotReachHere() in Type::typerr()
  • ... and 304 more: https://git.openjdk.org/jdk/compare/d51f4f471f3941294a987dcb68ee264fe27f018a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 15, 2022
@srmandal
Copy link
Author

/integrate

@srmandal
Copy link
Author

Can someone sponsor this PR?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 16, 2022
@openjdk
Copy link

openjdk bot commented Jul 16, 2022

@srmandal
Your change (at version 258971c) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Jul 18, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

Going to push as commit 5ae4320.
Since your change was applied there have been 330 commits pushed to the master branch:

  • efed7a7: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]
  • b2010a7: 8287805: Shenandoah: consolidate evacuate-update-root closures
  • ea8b75c: 8290334: Update FreeType to 2.12.1
  • 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
  • 92067e2: 8290137: riscv: small refactoring for add_memory_int32/64
  • 87340fd: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091
  • bc7a1ea: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline
  • 84f2314: 8286030: Avoid JVM crash when containers share the same /tmp dir
  • 4dd236b: 8290280: riscv: Clean up stack and register handling in interpreter
  • 522b657: Merge
  • ... and 320 more: https://git.openjdk.org/jdk/compare/d51f4f471f3941294a987dcb68ee264fe27f018a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2022
@openjdk openjdk bot closed this Jul 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 18, 2022
@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@prrace @srmandal Pushed as commit 5ae4320.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@srmandal srmandal deleted the 8284767 branch October 20, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants