Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285477: Add a PRECISION public static field to j.l.Float and j.l.Double #8362

Closed
wants to merge 3 commits into from

Conversation

rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Apr 22, 2022

Add useful constants specified in IEEE 754.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8285477: Add a PRECISION public static field to j.l.Float and j.l.Double
  • JDK-8285241: Add a PRECISION public static field to j.l.Float and j.l.Double (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8362/head:pull/8362
$ git checkout pull/8362

Update a local copy of the PR:
$ git checkout pull/8362
$ git pull https://git.openjdk.java.net/jdk pull/8362/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8362

View PR using the GUI difftool:
$ git pr show -t 8362

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8362.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2022

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rgiulietti
Copy link
Contributor Author

The precision of float resp. double values, as defined by IEEE 754, is not easily derivable from the constants in the java.lang.Float resp. java.lang.Double classes. These values (24 resp. 53) are used in some places in the OpenJDK code base, where they appear as literals or even as derived literals, like 23 and 52. Hence, usages of these values are harder to find than necessary.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 22, 2022
@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 22, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2022

Webrevs

/**
* Maximum exponent a finite {@code double} variable may have.
* It is equal to the value returned by
* {@code Math.getExponent(Double.MAX_VALUE)}.
*
* @since 1.6
*/
public static final int MAX_EXPONENT = 1023;
public static final int MAX_EXPONENT = (1 << (SIZE - PRECISION - 1)) - 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the expected value as a comment; e.g.

(1 << (SIZE - PRECISION - 1)) - 1; // 1023

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

/**
* The number of bits in the significand of a {@code float} value.
* This is the parameter N in section {@jls 4.2.3} of
* <em>The Java Language Specification</em>.
Copy link
Member

@jddarcy jddarcy Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "cite" rather than "em" tags for references to the JLS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285477: Add a PRECISION public static field to j.l.Float and j.l.Double

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 1e79ded: 8284889: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc timed out
  • 414918d: 8285389: EdDSA trimming zeros
  • 293bc5e: 8129778: Few awt test fail for Solaris 11 with RuntimeException
  • 36f2e52: 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu
  • 32593df: 8279888: Local variable independently used by multiple loops can interfere with loop optimizations
  • 4c22a9b: 8282823: javac should constrain more uses of preview APIs
  • dc63584: 8273115: CountedLoopEndNode::stride_con crash in debug build with -XX:+TraceLoopOpts
  • c5aa75d: 8285439: remove unused os::fsync
  • 9d9f4e5: 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops*
  • 08024d9: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/165f516101016e84ebea1444fbac9b3880a940f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2022
@rgiulietti
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@rgiulietti
Your change (at version b4c1b61) is now ready to be sponsored by a Committer.

@jddarcy
Copy link
Member

jddarcy commented Apr 25, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

Going to push as commit fb60594.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 1e79ded: 8284889: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc timed out
  • 414918d: 8285389: EdDSA trimming zeros
  • 293bc5e: 8129778: Few awt test fail for Solaris 11 with RuntimeException
  • 36f2e52: 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu
  • 32593df: 8279888: Local variable independently used by multiple loops can interfere with loop optimizations
  • 4c22a9b: 8282823: javac should constrain more uses of preview APIs
  • dc63584: 8273115: CountedLoopEndNode::stride_con crash in debug build with -XX:+TraceLoopOpts
  • c5aa75d: 8285439: remove unused os::fsync
  • 9d9f4e5: 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops*
  • 08024d9: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/165f516101016e84ebea1444fbac9b3880a940f3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2022
@openjdk openjdk bot closed this Apr 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@jddarcy @rgiulietti Pushed as commit fb60594.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rgiulietti rgiulietti deleted the JDK-8285477 branch Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants