8287013: StringConcatFactory: remove short and byte mixers/prependers

[cl4es]

The current short and byte mixers and prependers simply delegate to the int variants. At the LambdaForm level the values has already been implicitly cast to int, so removing this indirection and directly adapting to call the int-based variants is possible.

This is a cleanup with minimal effect on bootstrap overhead and peak performance, since all the LF logic only deals with basic types (where byte and short and other subword primitives has been widened to ints anyhow).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8287013: StringConcatFactory: remove short and byte mixers/prependers

Reviewers

• Jim Laskey (@JimLaskey - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8786/head:pull/8786
$ git checkout pull/8786

Update a local copy of the PR:
$ git checkout pull/8786
$ git pull https://git.openjdk.java.net/jdk pull/8786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8786

View PR using the GUI difftool:
$ git pr show -t 8786

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8786.diff

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b25b8cdd)

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287013: StringConcatFactory: remove short and byte mixers/prependers

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

• 6e38666: 8286944: Loom: Common ContinuationEntry cookie handling
• 47500b2: 8286897: Loom: Cleanup x86_64 StubGenerator
• fc3edf2: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
• 022e717: 8286462: Incorrect copyright year for src/java.base/share/classes/jdk/internal/vm/FillerObject.java
• dbda0e2: 8286969: Add a new test library API to execute kinit in SecurityTools.java
• 26c7c92: 8286694: Incorrect argument processing in java launcher
• 2a2d54e: 8286984: (ch) Problem list java/nio/channels/FileChannel/LargeMapTest.java on Windows
• a617709: 8281268: Resolve duplication of test ClassTransformer class
• b523c88: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe
• 8323787: 8255439: System Tray icons get corrupted when windows scaling changes
• ... and 136 more: https://git.openjdk.java.net/jdk/compare/73c5e993e17f7435553edae79a1e8d70ece5493d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

/integrate

[openjdk]

Going to push as commit d5d19f5.
Since your change was applied there have been 165 commits pushed to the master branch:

• 828dc89: 8286893: G1: Recent card set coarsening statistics wrong
• 6569666: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong
• 40e99a1: 8285308: Win: Japanese logical fonts are drawn with wrong size
• 890771e: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character
• de74e0e: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable
• 9f562ef: 8286872: Refactor add/modify notification icon (TrayIcon)
• b089229: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
• 079312c: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing
• 7b19226: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
• e60d8b5: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException
• ... and 155 more: https://git.openjdk.java.net/jdk/compare/73c5e993e17f7435553edae79a1e8d70ece5493d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cl4es Pushed as commit d5d19f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.