-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287396 LIR_Opr::vreg_number() and data() can return negative number #8912
Conversation
treat data() as unsigned
👋 Welcome back dlong! A progress list of the required criteria for merging this PR into |
@dean-long The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@dean-long This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I got one timeout in the new test compiler/c1/TestTooManyVirtualRegistersMain.java from JDK-8261235. My change doubles the maximum number of virtual registers allowed, from 0x20000 to 0x40000. That probably explains why the test runs so long. Both numbers seem insanely large. Maybe we should set vreg_max to something more reasonable? |
Christian said in #2543: So yes, fix vreg_max. |
I set vreg_max to 10,000. I tried 1,000 first, but there were a few cases during testing where this would cause a bailout on hot methods. With 10,000, only CTW (forced compile of cold methods) and the TestTooManyVirtualRegistersMain.java stress test hit the limit. At 10,000 virtual registers, bailout happens after 8 seconds on a aarch64 debug build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks Vladimir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks more reasonable, thanks for fixing it! Have you also run some additional performance testing?
Thanks Christian. My first performance run showed some 1-2% regressions on a microbenchmark and a startup benchmark, so I ran it again and the regression disappeared, so I think it was noise. There was no regression for larger benchmarks like SPECjvm2008. |
Thanks Dean for evaluating the performance. Then I think it's good to go in. |
/integrate |
Going to push as commit cdb4768.
Your commit was automatically rebased without conflicts. |
@dean-long Pushed as commit cdb4768. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR does two things:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8912/head:pull/8912
$ git checkout pull/8912
Update a local copy of the PR:
$ git checkout pull/8912
$ git pull https://git.openjdk.java.net/jdk pull/8912/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8912
View PR using the GUI difftool:
$ git pr show -t 8912
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8912.diff