-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case #9021
Conversation
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@mlchung Thank you for pick up and fix the issue. The waiting time now is reduced from 10 seconds to 1 seconds. As most of the tests intermittent fail, the failure may be more popular now. Alternatively, it might be OK to run less cases in UnloadingTest.java (for example one or two call to tryUnload() in one test by separating the case into a few). But let's see if the intermittent failure is still rare enough. |
JDK-8287384 affects the tests using ForceGC for negative cases only. It will return with a fewer GC cycles of a shortened wait time between each cycle. It will be okay since a strongly reachable reference will never be GC'ed. |
/integrate |
Going to push as commit 2e332c2.
Your commit was automatically rebased without conflicts. |
This reapplies JDK-8287384 and adjust the number of GCs for negative case, i.e. the condition is never met that is used to verify a reference is not GC'ed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/9021/head:pull/9021
$ git checkout pull/9021
Update a local copy of the PR:
$ git checkout pull/9021
$ git pull https://git.openjdk.java.net/jdk pull/9021/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9021
View PR using the GUI difftool:
$ git pr show -t 9021
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/9021.diff