8289421: No-PCH build for Minimal VM was broken by JDK-8287001

[YaSuenag]

We see following error if we pass --with-jvm-variants=minimal --disable-precompiled-headers to configure script.

src/hotspot/share/compiler/disassembler.cpp:841:5: error: 'log_warning' was not declared in this scope; did you mean 'warning'?
[2022-06-29T01:25:45,429Z] 841 | log_warning(os)("Loading hsdis library failed");
[2022-06-29T01:25:45,429Z] | ^~~~~~~~~~~
[2022-06-29T01:25:45,429Z] | warning

Missing include of log.hpp

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289421: No-PCH build for Minimal VM was broken by JDK-8287001

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Jie Fu (@DamonFool - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9323/head:pull/9323
$ git checkout pull/9323

Update a local copy of the PR:
$ git checkout pull/9323
$ git pull https://git.openjdk.org/jdk pull/9323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9323

View PR using the GUI difftool:
$ git pr show -t 9323

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9323.diff

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5673491d)

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289421: No-PCH build for Minimal VM was broken by JDK-8287001

Reviewed-by: mbaesken, jiefu, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Looks good and trivial.

[tstuefe]

Ok. Thanks for the quick fix.

[YaSuenag]

Thank you for quick review! I will integrate it after GBA just in case.

[YaSuenag]

/integrate

[openjdk]

Going to push as commit 167ce4d.
Since your change was applied there has been 1 commit pushed to the master branch:

• 108cd69: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long

Your commit was automatically rebased without conflicts.

[openjdk]

@YaSuenag Pushed as commit 167ce4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.