Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName #9624

Closed
wants to merge 3 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jul 23, 2022

Fixed tests that use eName to print event name to print the class name. Plus some minor refactoring.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9624/head:pull/9624
$ git checkout pull/9624

Update a local copy of the PR:
$ git checkout pull/9624
$ git pull https://git.openjdk.org/jdk pull/9624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9624

View PR using the GUI difftool:
$ git pr show -t 9624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9624.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2022
@openjdk
Copy link

openjdk bot commented Jul 24, 2022

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

Reviewed-by: shade, sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 8159a1a: 8290706: Remove the support for inline contiguous allocations
  • 7318b22: 8289551: Conversions between bit representations of half precision values and floats
  • 2ae8e31: 8290669: Fix wording in sun.security.ec
  • 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
  • da9cc5c: 8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates
  • 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
  • 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
  • a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
  • 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2022
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of nits.
Otherwise, it looks good.
Thanks,
Serguei

@lmesnik
Copy link
Member Author

lmesnik commented Jul 26, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

Going to push as commit 1451642.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 8159a1a: 8290706: Remove the support for inline contiguous allocations
  • 7318b22: 8289551: Conversions between bit representations of half precision values and floats
  • 2ae8e31: 8290669: Fix wording in sun.security.ec
  • 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
  • da9cc5c: 8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates
  • 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
  • 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
  • a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
  • 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2022
@openjdk openjdk bot closed this Jul 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@lmesnik Pushed as commit 1451642.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants