8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

[TheShermanTanker]

CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a defined, but empty macro in libjli if it is not defined in the build system, which is incorrect

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

Reviewers

• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 4fb34244
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9669/head:pull/9669
$ git checkout pull/9669

Update a local copy of the PR:
$ git checkout pull/9669
$ git pull https://git.openjdk.org/jdk pull/9669/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9669

View PR using the GUI difftool:
$ git pr show -t 9669

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9669.diff

[bridgekeeper]

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheShermanTanker The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b8c0ea89)
• 00: Full (4fb34244)

[TheShermanTanker]

/integrate

[openjdk]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 5a539e8: 8291893: riscv: remove fence.i used in user space
• b2f0cbd: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work
• 891df21: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component
• d4fb91b: 8291956: Simplify the loop condition in sun.net.httpserver.Request constructor
• 20123ea: 8291901: IGV: Preference menu disappears after JDK-8288750

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@TheShermanTanker
Your change (at version 4fb3424) is now ready to be sponsored by a Committer.

[TheShermanTanker]

Comment to keep thread alive

[TheShermanTanker]

Merged with latest, currently awaiting further review and/or sponsorship

[magicus]

/sponsor

[openjdk]

@magicus The PR has been updated since the change author (@TheShermanTanker) issued the integrate command - the author must perform this command again.

[TheShermanTanker]

/integrate

[magicus]

/sponsor

[openjdk]

@TheShermanTanker
Your change (at version b8c0ea8) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit 8a804f6.
Since your change was applied there have been 5 commits pushed to the master branch:

• 5a539e8: 8291893: riscv: remove fence.i used in user space
• b2f0cbd: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work
• 891df21: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component
• d4fb91b: 8291956: Simplify the loop condition in sun.net.httpserver.Request constructor
• 20123ea: 8291901: IGV: Preference menu disappears after JDK-8288750

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus @TheShermanTanker Pushed as commit 8a804f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.