8292368: [ppc64] internal error g1BarrierSet.inline.hpp assert(oopDesc::is_oop(pre_val, true)) failed: Error

[TheRealMDoerr]

C1 patching stubs contain null Oops on PPC64. Null check is missing in JDK-8292077.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292368: [ppc64] internal error g1BarrierSet.inline.hpp assert(oopDesc::is_oop(pre_val, true)) failed: Error

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9968/head:pull/9968
$ git checkout pull/9968

Update a local copy of the PR:
$ git checkout pull/9968
$ git pull https://git.openjdk.org/jdk pull/9968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9968

View PR using the GUI difftool:
$ git pr show -t 9968

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9968.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[fisk]

Looks good.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292368: [ppc64] internal error g1BarrierSet.inline.hpp assert(oopDesc::is_oop(pre_val, true)) failed: Error

Reviewed-by: eosterlund, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (980e8cc6)

[shipilev]

Looks fine.

[TheRealMDoerr]

Thanks for the reviews!

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit cf00677.
Since your change was applied there have been 14 commits pushed to the master branch:

• d92e00a: 8292763: JDK-8292716 breaks configure without jtreg
• 486f90c: 8292716: Configure should check that jtreg is of the required version
• b4e1aa8: 8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag
• 84936e9: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
• 259ba86: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter
• a85a723: 8292351: tty should always live
• 4da1745: 8291118: [vectorapi] Optimize the implementation of lanewise FIRST_NONZERO
• 38a8191: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets.
• 27af014: 8292743: Missing include resourceHash.hpp
• f58aaab: 8292262: adjust timeouts in several M&M tests
• ... and 4 more: https://git.openjdk.org/jdk/compare/aa9b8f04bf74d5fa00f2b27895e7369abea3a930...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit cf00677.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.