-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264179: [TESTBUG] Some compiler tests fail when running without C2 #1091
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
I guess this should have been a dependent PR on top of #1090? |
37a60ef
to
ad5eceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! |
Going to push as commit 281aeb9.
Your commit was automatically rebased without conflicts. |
I backport this test-only change for parity with 11.0.17-oracle.
I had to resolve TestRangeCheckPredicatesControl.java.
Two tests are not in 11, so I skipped the patch:
TestSubTypeCheckMacroNodeWrongMem.java came in 15 with JDK-8239367
Vec_MulAddS2I.java came in 12 with JDK-8214751
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1091/head:pull/1091
$ git checkout pull/1091
Update a local copy of the PR:
$ git checkout pull/1091
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1091/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1091
View PR using the GUI difftool:
$ git pr show -t 1091
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1091.diff