Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264179: [TESTBUG] Some compiler tests fail when running without C2 #1091

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 16, 2022

I backport this test-only change for parity with 11.0.17-oracle.

I had to resolve TestRangeCheckPredicatesControl.java.
Two tests are not in 11, so I skipped the patch:
TestSubTypeCheckMacroNodeWrongMem.java came in 15 with JDK-8239367
Vec_MulAddS2I.java came in 12 with JDK-8214751


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8264179: [TESTBUG] Some compiler tests fail when running without C2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1091/head:pull/1091
$ git checkout pull/1091

Update a local copy of the PR:
$ git checkout pull/1091
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1091

View PR using the GUI difftool:
$ git pr show -t 1091

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1091.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 16, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title Goetz backport 8264179 Backport aefc1560b51f0ce96d8f5ce396ba0d2fe08fd650 May 16, 2022
@openjdk openjdk bot changed the title Backport aefc1560b51f0ce96d8f5ce396ba0d2fe08fd650 8264179: [TESTBUG] Some compiler tests fail when running without C2 May 16, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels May 16, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 16, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 16, 2022

I guess this should have been a dependent PR on top of #1090?

@GoeLin GoeLin force-pushed the goetz_backport_8264179 branch from 37a60ef to ad5eceb Compare May 16, 2022
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented May 16, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264179: [TESTBUG] Some compiler tests fail when running without C2

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 16, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented May 18, 2022

Thanks for the review!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2022

Going to push as commit 281aeb9.
Since your change was applied there have been 5 commits pushed to the master branch:

  • d05bd5f: 8163498: Many long-running security libs tests
  • 0629ea6: 8209920: runtime/logging/RedefineClasses.java fail with OOME with ZGC
  • fef9e84: 8209150: [TESTBUG] Add logging to verify JDK-8197901 to a different test
  • 8f85dcf: 8285686: Update FreeType to 2.12.0
  • 80c9f24: 8235220: ClhsdbScanOops.java fails with sun.jvm.hotspot.types.WrongTypeException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 18, 2022
@openjdk openjdk bot closed this May 18, 2022
@openjdk openjdk bot removed ready rfr labels May 18, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2022

@GoeLin Pushed as commit 281aeb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8264179 branch May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants