-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266254: Update to use jtreg 6 #1241
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
The failing windows CI tests will pass when we actually bump the jtreg version in #1239 |
@shipilev @ArnoZeller @GoeLin: What do you think about bumping jtreg in 11u? Good idea or not? |
I think we need to run the entirety of |
I think at some point we will need this update. Be as said above we should be careful. I'll run it through our testing. |
I think we will also need:
|
@ArnoZeller thanks for your feedback. I’ll open backports for those 3 commits. |
Hi, |
@ArnoZeller I've raised the 3 backports as mentioned:
@GoeLin I'll look into that test failure, annoyingly the file was removed in JDK14u so will need some investigation. |
I've raised https://bugs.openjdk.org/browse/JDK-8290813 to cover the additional nashorn test fix |
nashorn test fix PR is here #1255. I've tested it locally and it passes on my machine. |
Hi, we still see the WebSocket tests failing. Did you test the patch with jtreg 6 in place? |
I did test the patch but assumed that I was running the tests incorrectly when I saw that. I also noted that the same failure occurs in jdk17u? |
Hi GoeLin,
record was added with JDK14 I guess. We might have to adopt this to 11. |
@ArnoZeller how many patches would be involved in this process? |
@gdams I do not mean to downport record - that would break the java spec. You just have to change the test coding to not use record. |
Understood - I'll see what I can do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. SAP nightlies show no regressions together with the other fixes.
@gdams This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 52 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Hi @gdams, |
@GoeLin I'll run the headful tests now to confirm that there are no broken ones. |
@GoeLin I've run a full test run and saw one test failure on macos which also fails with jtreg5 so is unrelated |
I'm a bit concerned about the windows tests. You say "The failing windows CI tests will pass when we actually bump the jtreg version in #1239". If this is the case, only integrate this change if 1239 is ready for integration, too. You may not break the pre-submit tests for others by this. |
@GoeLin #1239 is ready for integration. I've switched it from draft and set it up as a dependant PR so it should be good to go now. |
/integrate |
@GoeLin could you sponsor please? |
/sponsor |
Going to push as commit 00d9483.
Your commit was automatically rebased without conflicts. |
@RealCLanger @gdams Pushed as commit 00d9483. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport required in order to bump to jtreg 6
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1241/head:pull/1241
$ git checkout pull/1241
Update a local copy of the PR:
$ git checkout pull/1241
$ git pull https://git.openjdk.org/jdk11u-dev pull/1241/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1241
View PR using the GUI difftool:
$ git pr show -t 1241
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1241.diff