Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4819544: SwingSet2 JTable Demo throws NullPointerException #1411

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 8, 2022

I backport this for parity with 11.0.17-oracle.

Simple resolve.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-4819544: SwingSet2 JTable Demo throws NullPointerException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1411/head:pull/1411
$ git checkout pull/1411

Update a local copy of the PR:
$ git checkout pull/1411
$ git pull https://git.openjdk.org/jdk11u-dev pull/1411/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1411

View PR using the GUI difftool:
$ git pr show -t 1411

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1411.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 64d18d45ef885d5cdd893b7f56236d3f22b4b84c 4819544: SwingSet2 JTable Demo throws NullPointerException Oct 8, 2022
@openjdk
Copy link

openjdk bot commented Oct 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 8, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

4819544: SwingSet2 JTable Demo throws NullPointerException

Reviewed-by: phh, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 9ddc8b0: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 34b1178: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 18d8559: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 3622c42: 8293044: C1: Missing access check on non-accessible class
  • 094ca71: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 57c1b21: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • df5f253: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 3b9e482: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values
  • b6bf677: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • a84c773: 8263326: Remove ReceiverTypeData check from serviceability/sa/TestPrintMdo.java
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoeLin
Copy link
Member Author

GoeLin commented Oct 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit df6d5f8.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 53092b3: 8264593: debug.cpp utilities should be available in product builds.
  • 84e52a3: 8263871: On sem_destroy() failing we should assert
  • eb0b0ac: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 52c940e: 8254874: ZGC: JNIHandleBlock verification failure in stack watermark processing
  • 9ddc8b0: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 34b1178: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 18d8559: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 3622c42: 8293044: C1: Missing access check on non-accessible class
  • 094ca71: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 57c1b21: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin Pushed as commit df6d5f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_4819544 branch October 11, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants