Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class #1963

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 20, 2023

8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class

Reviewed-by: Yi Yang


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1963/head:pull/1963
$ git checkout pull/1963

Update a local copy of the PR:
$ git checkout pull/1963
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1963

View PR using the GUI difftool:
$ git pr show -t 1963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1963.diff

Webrev

Link to Webrev Comment

8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class

Reviewed-by: Yi Yang
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2023

👋 Welcome back sendaoYan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sendaoYan sendaoYan mentioned this pull request Jun 20, 2023
3 tasks
@openjdk openjdk bot changed the title Backport 924720f6fc8060fcd7024e6fca39223413f690ba 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 20, 2023
@sendaoYan sendaoYan changed the title 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Backport 924720f6fc8060fcd7024e6fca39223413f690ba Jun 20, 2023
@openjdk openjdk bot changed the title Backport 924720f6fc8060fcd7024e6fca39223413f690ba 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented Jun 20, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. Lgtm.

@phohensee
Copy link
Member

Please enable pre-submit testing on your fork.

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

⚠️ @sendaoYan the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8236045
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 64c9026: 8300751: [17u] Remove duplicate entry in javac.properties

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2023
@sendaoYan
Copy link
Member Author

/integrate

@sendaoYan
Copy link
Member Author

Please enable pre-submit testing on your fork.

OK

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@sendaoYan
Your change (at version c10e503) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

Tagged the JBS issue.

@GoeLin
Copy link
Member

GoeLin commented Jun 22, 2023

Hi @sandaoyan,
please don't integrate before the JBS issue is labeled jdk11u-fix-yes.
Please merge head which will restart the Pre-submit tests.
Please state what testing you did. Did you run the test?

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit 4a7557e.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 513732d: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 817254d: 8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore
  • 77837e3: 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout
  • e30705e: 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header
  • 30f0493: 8239007: java/math/BigInteger/largeMemory/ tests should be disabled on 32-bit platforms
  • 114bb9a: 8239537: cgroup MetricsTester testMemorySubsystem fails sometimes when testing memory.kmem.tcp.usage_in_bytes
  • 5506f90: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"
  • ffe80b2: 8237183: Bug ID missing for test in patch which fixed JDK-8230665
  • 50f876c: 8232101: (sctp) Add minimal sanity tests for SCTP
  • ef1e4fa: 8224729: Cleanups in sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/2cc45963906f088a56aad599a58e2842a214de7b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@phohensee @sendaoYan Pushed as commit 4a7557e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

sendaoYan commented Jun 25, 2023

Hi @sandaoyan, please don't integrate before the JBS issue is labeled jdk11u-fix-yes. Please merge head which will restart the Pre-submit tests. Please state what testing you did. Did you run the test?

@GoeLin

  • Pre-submit tests is done.

  • This is TESTBUG fix, so I run this testcase only.

  1. Before this PR merged(jdk11u repo), this testcase run fail:

image

  1. After this PR merged(jdk11u-dev repo), this testcase run pass on the same machine with same test command and the same jdk binary:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants