Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297923: java.awt.ScrollPane broken after multiple scroll up/down #2047

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 18, 2023

I backport this for parity with 11.0.21-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8297923: java.awt.ScrollPane broken after multiple scroll up/down (Bug - P3)
  • JDK-8310054: ScrollPane insets are incorrect (Bug - P3)
  • JDK-8311689: Wrong visible amount in Adjustable of ScrollPane (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2047/head:pull/2047
$ git checkout pull/2047

Update a local copy of the PR:
$ git checkout pull/2047
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2047

View PR using the GUI difftool:
$ git pr show -t 2047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2047.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f18ecea50fae69e4bad8479c37701fb08c5ee460 8297923: java.awt.ScrollPane broken after multiple scroll up/down Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297923: java.awt.ScrollPane broken after multiple scroll up/down
8310054: ScrollPane insets are incorrect
8311689: Wrong visible amount in Adjustable of ScrollPane

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2023

Going to push as commit 6747c78.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2023
@openjdk openjdk bot closed this Jul 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2023
@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@GoeLin Pushed as commit 6747c78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant