Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315214: Do not run sun/tools/jhsdb tests concurrently #2244

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 31, 2023

Backport 8315214


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315214 needs maintainer approval

Issue

  • JDK-8315214: Do not run sun/tools/jhsdb tests concurrently (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2244/head:pull/2244
$ git checkout pull/2244

Update a local copy of the PR:
$ git checkout pull/2244
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2244

View PR using the GUI difftool:
$ git pr show -t 2244

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2244.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e7e2bcf3560e1ad39516fb604e4d8bf85bb54e0 8315214: Do not run sun/tools/jhsdb tests concurrently Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 31, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Nov 3, 2023
@GoeLin
Copy link
Member

GoeLin commented Nov 7, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@GoeLin
8315214: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315214: Do not run sun/tools/jhsdb tests concurrently

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • b64a1ac: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 80d3bb4: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • 1f67ffb: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • f6bdbe8: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • feb051f: 8316906: Clarify TLABWasteTargetPercent flag
  • 9abfdde: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 18d616d: 8306280: Open source several choice AWT tests
  • f993ef5: 8284331: Add sanity check for signal handler modification warning.
  • 92c5062: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d90b9ac: 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/2fbb4b92bdcbc3a478c06cc6c904391c1d2e326e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 7, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Nov 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit 75daf18.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
  • 2aca53f: 8026393: jarsigner never shows a warning in badKeyUsage case
  • ff19eeb: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
  • 2f3fc25: 8232135: Add diagnostic output to test java/util/ProcessBuilder/Basic.java
  • 48f1f39: 8230435: Replace wildcard address with loopback or local host in tests - part 22
  • b64a1ac: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 80d3bb4: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • 1f67ffb: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/2fbb4b92bdcbc3a478c06cc6c904391c1d2e326e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@MBaesken Pushed as commit 75daf18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants