Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319187: Add three eMudhra emSign roots #2290

Closed
wants to merge 7 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 22, 2023

I backport this for parity with 11.0.23-oracle.
Adapt the location of the certs and the hash in the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319187 needs maintainer approval

Issue

  • JDK-8319187: Add three eMudhra emSign roots (Enhancement - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2290/head:pull/2290
$ git checkout pull/2290

Update a local copy of the PR:
$ git checkout pull/2290
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2290

View PR using the GUI difftool:
$ git pr show -t 2290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2290.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19 8319187: Add three eMudhra emSign roots Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 22, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@MBaesken
Copy link
Member

What happened to EmSignRootG2CA.java from openjdk/jdk@0bda467 ?

And is there a reason to have 10 files in the change ? Is it 2 backports in one, if so why ?

@luchenlin
Copy link
Contributor Author

luchenlin commented Nov 24, 2023

What happened to EmSignRootG2CA.java from openjdk/jdk@0bda467 ?

And is there a reason to have 10 files in the change ? Is it 2 backports in one, if so why ?

hi @MBaesken, tests all pass local, and this one is depending on JDK-8318759, i will update this after that one merged.

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 28, 2023

@luchenlin Please rebase since JDK-8318759 integrated and the apply for approval. Thanks!

# Conflicts:
#	test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants