-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319187: Add three eMudhra emSign roots #2290
Conversation
# Conflicts: # test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
What happened to EmSignRootG2CA.java from openjdk/jdk@0bda467 ? And is there a reason to have 10 files in the change ? Is it 2 backports in one, if so why ? |
hi @MBaesken, tests all pass local, and this one is depending on JDK-8318759, i will update this after that one merged. |
|
@luchenlin Please rebase since JDK-8318759 integrated and the apply for approval. Thanks! |
# Conflicts: # test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
I backport this for parity with 11.0.23-oracle.
Adapt the location of the certs and the hash in the test.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2290/head:pull/2290
$ git checkout pull/2290
Update a local copy of the PR:
$ git checkout pull/2290
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2290/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2290
View PR using the GUI difftool:
$ git pr show -t 2290
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2290.diff
Webrev
Link to Webrev Comment