-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder #319
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review and the approval! |
Going to push as commit 1e6682a.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 1e6682a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Almost clean backport of JDK-8247403. Rejected hunks:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/319/head:pull/319
$ git checkout pull/319
Update a local copy of the PR:
$ git checkout pull/319
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/319/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 319
View PR using the GUI difftool:
$ git pr show -t 319
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/319.diff