Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events #350

Closed

Conversation

@reinrich
Copy link
Contributor

@reinrich reinrich commented Sep 15, 2021

Hi all,

this pull request contains a backport of commit 72530ef from the openjdk/jdk repository. The fix is small and applies cleanly.

I would like to backport this to jdk11u as a fix for the describe performance issue.

The commit being backported was authored by Richard Reingruber on 7 Jul 2021 and was reviewed by Vladimir Kozlov, Roland Westrelin and Nils Eliasson.

Thanks!
Richard.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/350.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 72530ef666ce2ace899cf34faefe715539d1ee25 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@reinrich This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 15, 2021
@reinrich reinrich marked this pull request as ready for review Sep 16, 2021
@openjdk openjdk bot added the rfr label Sep 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Webrevs

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Mailing list message from Volker Simonis on jdk-updates-dev:

Looks good to me.

Happy high speed debugging :)

Richard Reingruber <rrich at openjdk.java.net> schrieb am Do., 16. Sept. 2021,
08:25:

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Mailing list message from Reingruber, Richard on jdk-updates-dev:

Thanks Volker! :)

From: Volker Simonis <volker.simonis at gmail.com>
Sent: Donnerstag, 16. September 2021 09:51
To: Richard Reingruber <rrich at openjdk.java.net>
Cc: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
Subject: Re: [jdk11u-dev] RFR: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events

Looks good to me.

Happy high speed debugging :)

Richard Reingruber <rrich at openjdk.java.net<mailto:rrich at openjdk.java.net>> schrieb am Do., 16. Sept. 2021, 08:25:
Hi all,

this pull request contains a backport of commit 72530ef from the openjdk/jdk repository. The fix is small and applies cleanly.

I would like to backport this to jdk11u as a fix for the describe performance issue.

The commit being backported was authored by Richard Reingruber on 7 Jul 2021 and was reviewed by Vladimir Kozlov, Roland Westrelin and Nils Eliasson.

Thanks!
Richard.

-------------

Commit messages:
- Backport 72530ef

Changes: https://git.openjdk.java.net/jdk11u-dev/pull/350/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=350&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8269574
Stats: 14 lines in 1 file changed: 7 ins; 7 del; 0 mod
Patch: https://git.openjdk.java.net/jdk11u-dev/pull/350.diff
Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/350/head:pull/350

PR: https://git.openjdk.java.net/jdk11u-dev/pull/350

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Sep 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@reinrich Unable to acquire the integration lock; aborting integration. The error has been logged and will be investigated.

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Sep 21, 2021

/integrate
Hope it works now...

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

Going to push as commit 9accd6b.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 0d49433: 8272850: Drop zapping values in the Zap* option descriptions
  • 78e18d4: 8272318: Improve performance of HeapDumpAllTest
  • 7627023: 8215410: Regression test for JDK-8214994
  • 8a2cb87: 8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently
  • 86cd9ba: 8213189: Make restricted headers in HTTP Client configurable and remove Date by default
  • 18e519c: 8256066: Tests use deprecated TestNG API that is no longer available in new versions
  • 0a40175: 8216318: The usage of Disposer in the java.awt.Robot can be deleted
  • ef06175: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails
  • b65b79b: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 9f51a40: 8270344: Session resumption errors
  • ... and 21 more: https://git.openjdk.java.net/jdk11u-dev/compare/9437d45b4b82e9b60317acb248a215f1aa4f972e...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@reinrich Pushed as commit 9accd6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant