Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently #363

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 17, 2021

Hi all,

this pull request contains a backport of JDK-8129310 from the openjdk/jdk repository.

The commit being backported was authored by Chris Yin on 20 Nov 2018 and was reviewed by Daniel Fuchs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/363/head:pull/363
$ git checkout pull/363

Update a local copy of the PR:
$ git checkout pull/363
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/363/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 363

View PR using the GUI difftool:
$ git pr show -t 363

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/363.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport fb6de4b0b65b115e1e70e7476d0627a424baad9f 8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2021

Webrevs

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 8a2cb87.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 86cd9ba: 8213189: Make restricted headers in HTTP Client configurable and remove Date by default
  • 18e519c: 8256066: Tests use deprecated TestNG API that is no longer available in new versions
  • 0a40175: 8216318: The usage of Disposer in the java.awt.Robot can be deleted
  • ef06175: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails
  • b65b79b: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 9f51a40: 8270344: Session resumption errors
  • a925af4: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • 9d29c77: 8217633: Configurable extensions with system properties
  • 1bed6cd: 8253682: The AppletInitialFocusTest1.java is unstable
  • 48e5f41: 6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
  • ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/777039b1e6a243d005d49d29e1d6d92aa6941daf...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@RealCLanger Pushed as commit 8a2cb87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant