-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256066: Tests use deprecated TestNG API that is no longer available in new versions #367
8256066: Tests use deprecated TestNG API that is no longer available in new versions #367
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@TheRealMDoerr Unable to acquire the integration lock; aborting integration. The error has been logged and will be investigated. |
/integrate |
Going to push as commit 18e519c.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 18e519c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8256066.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/367/head:pull/367
$ git checkout pull/367
Update a local copy of the PR:
$ git checkout pull/367
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/367/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 367
View PR using the GUI difftool:
$ git pr show -t 367
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/367.diff