Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report #38

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jun 16, 2021

I would like to backport this patch to openjdk11u for parity with Oracle 11.0.13-oracle.

The original patch does not apply cleanly, conflicts in both debug.hpp and debug.cpp, have been resolved manually.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/38/head:pull/38
$ git checkout pull/38

Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/38/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 38

View PR using the GUI difftool:
$ git pr show -t 38

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/38.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 16, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cd1c17c0a6416a8d16cf2035f3e97dba95b6b8af 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jun 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 16, 2021

Webrevs

Copy link
Contributor

@eastig eastig left a comment

LGTM

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Jun 17, 2021

LGTM

Thanks, @eastig

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 29, 2021

Looks good. I'll approve it after running it once through our regression testing.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 1, 2021
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Jul 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

Going to push as commit 71f793e.
Since your change was applied there have been 39 commits pushed to the master branch:

  • e56abca: 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan
  • 3ed6237: 8269614: [s390] Interpreter checks wrong bit for slow path instance allocation
  • aa79d2b: 8262409: sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions. SSL test failures caused by java failed with "Server reported the wrong exception"
  • 65fe466: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
  • af4b373: 8163326: Update the default enabled cipher suites preference
  • 02bfc22: 8266749: AArch64: Backtracing broken on PAC enabled systems
  • 0e4fdcf: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
  • 725e516: Merge
  • a24f045: Added tag jdk-11.0.12+6 for changeset 91e81ac08854
  • bb5b2cb: 8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired
  • ... and 29 more: https://git.openjdk.java.net/jdk11u-dev/compare/23719ae59cf63f32c6a236f4ab6dbea1ed7bbdbe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@zhengyu123 Pushed as commit 71f793e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants