Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 44ae643b2b4 #855

Closed
wants to merge 1 commit into from
Closed

Backport 44ae643b2b4 #855

wants to merge 1 commit into from

Conversation

basil
Copy link
Contributor

@basil basil commented Mar 6, 2022

Hi all,

This pull request contains a clean backport of commit 44ae643b2b4 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero.

See JDK-8210649 and MCOMPILER-346 for more information.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/855/head:pull/855
$ git checkout pull/855

Update a local copy of the PR:
$ git checkout pull/855
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 855

View PR using the GUI difftool:
$ git pr show -t 855

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/855.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Mar 6, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2022

Hi @basil, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user basil" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@basil
Copy link
Contributor Author

basil commented Mar 6, 2022

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Mar 6, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2022

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Mar 17, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 17, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2022

Webrevs

@basil
Copy link
Contributor Author

basil commented Mar 17, 2022

CC @lahodaj @vicente-romero-oracle

@TheRealMDoerr
Copy link
Contributor

This PR is not recognized as backport. I suggest to change the title to "Backport 44ae643" and let the Skara Bot do the work. You will also have to request "jdk11u-fix-request" approval (see https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix).

@basil basil changed the title 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) Backport 44ae643b2b4 Mar 18, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 18, 2022
@basil
Copy link
Contributor Author

basil commented Mar 18, 2022

Going to try creating this PR again using SKARA CLI tooling].

@basil basil closed this Mar 18, 2022
@basil
Copy link
Contributor Author

basil commented Mar 18, 2022

Going to try creating this PR again using SKARA CLI tooling.

Done in #919.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants