8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)

[basil]

Hi all,

This pull request contains a clean backport of commit 44ae643b2b49b66b1fff4c151c17972c6b683cc0 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero.

See JDK-8210649 and MCOMPILER-346 for more information.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/919/head:pull/919
$ git checkout pull/919

Update a local copy of the PR:
$ git checkout pull/919
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 919

View PR using the GUI difftool:
$ git pr show -t 919

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/919.diff

[bridgekeeper]

👋 Welcome back basil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

@basil This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)

Do not clean trees after last round of annotation processing, if the trees won't be re-entered again.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 23af0b1: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (8fc13642)

[basil]

Testing done

• tier1 test run via GitHub Actions
• make run-test TEST=test/langtools/tools/javac/processing (to cover the test in this PR)

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/langtools/tools/javac/processing         172   172     0     0   
==============================
TEST SUCCESS

[basil]

/integrate

[openjdk]

@basil
Your change (at version 8fc1364) is now ready to be sponsored by a Committer.

[basil]

CC @TheRealMDoerr if you're interested

[basil]

In addition to the unit/integration tests, I verified locally in an end-to-end testing scenario that this backport resolves the issue I was experiencing running Maven.

[basil]

Issues resolved by this backport:

• JDK-8210649
• JDK-8216202
• MCOMPILER-346
• MCOMPILER-415

[jerboaa]

@basil Please only /integrate once you've got jdk11u-fix-yes label in JBS by an 11u maintainer. See the process description here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u

[TheRealMDoerr]

You still need to request approval for 11u backports and justify why it should be done. See https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix section "Request and await approval for the fix". If you don't have JBS access, please provide the information and ask somebody to add it to the JBS issue.

[basil]

Please only /integrate once you've got jdk11u-fix-yes label in JBS by an 11u maintainer. See the process description here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u

@jerboaa Sorry, this is my first time submitting a PR to this project and I was unfamiliar with the process. I will read the link; thank you!

You still need to request approval for 11u backports and justify why it should be done. See https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix section "Request and await approval for the fix". If you don't have JBS access, please provide the information and ask somebody to add it to the JBS issue.

@TheRealMDoerr I do not have JBS access. Can someone please submit the following comment with the jdk11u-fix-request label:

When compiling source code with compilation errors using Maven and Java 11, I frequently encounter the AssertionError from JDK-8210649 (tracked by MCOMPILER-346) with <release>11</release> and the NullPointerException from JDK-8216202 (tracked by MCOMPILER-415) with <release>8</release>. That is, rather than getting an informative error message that tells me the nature of the compilation error, I get an unhelpful stack trace emanating from the depths of the JDK, which does not get me any closer to fixing the compilation error and compiling my code. Both issues have the same root cause and were resolved by openjdk/jdk@44ae643b2b4. Backporting this commit to jdk11u-dev resolves both issues and eliminates a developer productivity pain point. Not only have I done a tier1 test run via GitHub Actions and executed the test from openjdk/jdk@44ae643b2b4 locally by running make run-test TEST=test/langtools/tools/javac/processing, but also I have verified locally in an end-to-end testing scenario that this backport resolves the issues I was experiencing running Maven with both <release>11</release> (i.e., the AssertionError) and <release>8</release> (i.e., the NullPointerException).

[phohensee]

Done.

[basil]

Done.

@phohensee Thank you!

[basil]

@phohensee Sorry to trouble you one more time, but I had a typo... meant to write:

When compiling source code with compilation errors using Maven and Java 11, I frequently encounter the AssertionError from JDK-8210649 (tracked by MCOMPILER-346) with <release>11</release> and the NullPointerException from JDK-8216202 (tracked by MCOMPILER-415) with <release>8</release>.

Note the two different JDK bugs.

[phohensee]

Updated.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit dd6ba08.
Since your change was applied there have been 2 commits pushed to the master branch:

• e6f8c1e: 8240734: ModuleHashes attribute not reproducible between builds
• 23af0b1: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @basil Pushed as commit dd6ba08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.