New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8247589: Implementation of Alpine Linux/x64 Port #910
Conversation
👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@voitylov Could you please resolve conflicts? Thanks! |
@jerboaa merge conflict with 8246494 is now resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me.
@voitylov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @RealCLanger) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I'll run this patch through SAP's testing tonight. I'm going to approve it when we don't see regressions. |
Thanks Christoph! |
Hi, we noticed a small issue in test/jdk/tools/launcher/Test7029048.java . test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 |
@MBaesken thanks for spotting this. GHA gives "E: Version '9.4.0-1ubuntu1~20.04' for 'gcc-9' was not found" which is unrelated to this change. |
Yes, about to fix this with openjdk/jdk11u#36 JDK-8283778 |
@MBaesken I'd like to play it safe and kindly ask you to rerun the SAP nightly testing, if possible. |
@RealCLanger I see my ask to Matthias crossed with your review. Can I assume SAP is happy with the updated version? |
Yes, the patch is running in our nightlies for days now - no further issues. 😄 |
/integrate |
/sponsor |
Going to push as commit 2faa216.
Your commit was automatically rebased without conflicts. |
@AlexanderScherbatiy @voitylov Pushed as commit 2faa216. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1].
Original changeset does not apply cleanly because of:
8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports,
8215445: Enable building for Windows in WSL
8257913: Add more known library locations to simplify Linux cross-compilation
8244592: Start supporting SOURCE_DATE_EPOCH
8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes
Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions.
[1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/910/head:pull/910
$ git checkout pull/910
Update a local copy of the PR:
$ git checkout pull/910
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/910/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 910
View PR using the GUI difftool:
$ git pr show -t 910
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/910.diff