Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292579: (tz) Update Timezone Data to 2022c #54

Closed
wants to merge 1 commit into from

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Sep 14, 2022

Updates the TimezoneData to 2022c. This is a backport from tip, except for the modification to files added by JDK-8028265, not present in 11.

Adding the change to jdk11u instead of jdk11u-dev as this change should probably be included in the Q3 release as suggested in openjdk/jdk8u-dev#119


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.org/jdk11u pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/54.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2022

👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@alvdavi alvdavi changed the title 8292579: (tz) Update Timezone Data to 2022c Backport 98d85e6f594bf34b97407c470b14791af0a2bc53 Sep 14, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2022
@openjdk openjdk bot changed the title Backport 98d85e6f594bf34b97407c470b14791af0a2bc53 8292579: (tz) Update Timezone Data to 2022c Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Sep 14, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks identical to the 17u version, paths adjusted from 19u due to the absence of JDK-8257733

@gnu-andrew
Copy link
Member

I've flagged the bug jdk11u-critical-request on your behalf.

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@alvdavi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292579: (tz) Update Timezone Data to 2022c

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2022
@gnu-andrew
Copy link
Member

This has been approved (jdk11u-critical-yes). Please integrate and I'll sponsor.

@alvdavi
Copy link
Contributor Author

alvdavi commented Sep 24, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 24, 2022
@openjdk
Copy link

openjdk bot commented Sep 24, 2022

@alvdavi
Your change (at version 105a80e) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 25, 2022

Going to push as commit 2f695bb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2022
@openjdk openjdk bot closed this Sep 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 25, 2022
@openjdk
Copy link

openjdk bot commented Sep 25, 2022

@gnu-andrew @alvdavi Pushed as commit 2f695bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants