Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292579: (tz) Update Timezone Data to 2022c #119

Closed
wants to merge 1 commit into from

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Sep 12, 2022

Backport of tzdata 2022c to jdk8u using the rearguard data for JDK8


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/119/head:pull/119
$ git checkout pull/119

Update a local copy of the PR:
$ git checkout pull/119
$ git pull https://git.openjdk.org/jdk8u-dev pull/119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 119

View PR using the GUI difftool:
$ git pr show -t 119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/119.diff

Backport-of: 98d85e6f594bf34b97407c470b14791af0a2bc53
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2022

👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 98d85e6f594bf34b97407c470b14791af0a2bc53 8292579: (tz) Update Timezone Data to 2022c Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 12, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Sep 13, 2022

@alvdavi @gnu-andrew We should probably try to get this into jdk8u as a critical fix for October. If so, re-create the PR in https://github.com/openjdk/jdk8u. Thoughts? Please also be sure to have this in JDK 11 and JDK 17. Thanks!

@gnu-andrew
Copy link
Member

This is quite a disruptive update due to changes in 2022b. While we need the timezone changes, I'll have to look at how those changes were handled in trunk. Last I checked, this was still being debated there.

@gnu-andrew
Copy link
Member

One thing I don't immediately see is a new translation key to handle Europe/Kyiv. We had to patch that locally when using 2022b&c.

@jerboaa
Copy link
Contributor

jerboaa commented Sep 30, 2022

@alvdavi Please close this one as it's been fixed with openjdk/jdk8u#19 and will come to jdk8u-dev with a merge from jdk8u. Thanks!

@alvdavi alvdavi closed this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants