8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

[jerboaa]

Please review this almost clean backport (modulo copyright header in DisabledAlgorithmConstraints) in the product code. The test needed some changes to make it work (removal of text block syntax, ClassFileInstaller import change).

It fixes a regression introduced with JDK-8269039: Disable SHA-1 Signed JARs which was included in 11.0.17 (note that 11.0.16 is not affected as JDK-8269039 is not there). This should be low-risk as it mainly removes use of java.util.Calendar API usage in DisabledAlgorithmConstraints which can cause issues with applications that contain CalendarDataProviders in signed jars. See JDK-8297684 for details.

Proposing as critical fix so that we don't have another release with that regression.

Regression test fails prior and passes after the product fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/65/head:pull/65
$ git checkout pull/65

Update a local copy of the PR:
$ git checkout pull/65
$ git pull https://git.openjdk.org/jdk11u pull/65/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 65

View PR using the GUI difftool:
$ git pr show -t 65

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/65.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (5faa16cb)

[RealCLanger]

Looks good. I'll run this PR and the 17u one through our nightlies.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Looks good. I'll run this PR and the 17u one through our nightlies.

@RealCLanger Thanks for the review! How do your nightlies look? OK to integrate (I see jdk11u-critical-yes on the bug)?

[GoeLin]

The nighties are all green. ok to go. I checked before approving :)

[jerboaa]

The nighties are all green. ok to go. I checked before approving :)

Ah, thanks.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 445ab52.

[openjdk]

@jerboaa Pushed as commit 445ab52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.