Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations #68

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Dec 22, 2020

I'd like to backport 8254854 to 13u for parity with 11u.
The patch doesn't apply cleanly since 13u doesn't have cgroups v2 support (JDK-8231111), so it reapplied manually to Metrics::setSubSystemPath() method instead of CgroupV1Subsystem::setSubSystemControllerPath() from the original patch.
Tested with tier1 and container tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/68/head:pull/68
$ git checkout pull/68

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a0b687bfb279761b79d3fbad8f9dfae9b12c225e 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Dec 22, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ea904d8: 8257242: [macOS] Java app crashes while switching input methods
  • 9db1121: 8255603: Memory/Performance regression after JDK-8210985
  • 164abd4: 8239000: handle ContendedPaddingWidth in vm_version_ppc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dimitryc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 23, 2020
@kvergizova
Copy link
Contributor Author

kvergizova commented Dec 23, 2020

/integrate

@openjdk openjdk bot added the sponsor label Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@kvergizova
Your change (at version 7a1c3b0) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

dimitryc commented Dec 23, 2020

/sponsor

@openjdk openjdk bot closed this Dec 23, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dimitryc @kvergizova Since your change was applied there have been 3 commits pushed to the master branch:

  • ea904d8: 8257242: [macOS] Java app crashes while switching input methods
  • 9db1121: 8255603: Memory/Performance regression after JDK-8210985
  • 164abd4: 8239000: handle ContendedPaddingWidth in vm_version_ppc

Your commit was automatically rebased without conflicts.

Pushed as commit cc78d10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8254854 branch Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants