Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk17 Public archive

8269276: Additional tests for MessageDigest with different providers #250

Closed
wants to merge 2 commits into from
Closed

8269276: Additional tests for MessageDigest with different providers #250

wants to merge 2 commits into from

Conversation

sisahoo
Copy link
Member

@sisahoo sisahoo commented Jul 14, 2021 •
edited by openjdk bot
Loading

Few more Test cases added to verify MessageDigest instance generated through different providers.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269276: Additional tests for MessageDigest with different providers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/250/head:pull/250
$ git checkout pull/250

Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.java.net/jdk17 pull/250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 250

View PR using the GUI difftool:
$ git pr show -t 250

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/250.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2021

👋 Welcome back ssahoo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2021
@openjdk
Copy link

openjdk bot commented Jul 14, 2021

@sisahoo The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.java.net label Jul 14, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2021 •
edited
Loading

Webrevs

valeriepeng
valeriepeng reviewed Jul 14, 2021
View reviewed changes
test/jdk/sun/security/pkcs11/MessageDigest/ReinitDigest.java Outdated
if (!md1.getAlgorithm().equals(md2.getAlgorithm())) {
throw new RuntimeException("Algorithm name should equal");
}
if (md1.getProvider().equals(md2.getProvider())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: calls getName() since the error message says that the comparison is based on provider name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. It was meant to be provider name check. Thanks..

@openjdk
Copy link

openjdk bot commented Jul 14, 2021 •
edited
Loading

@sisahoo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269276: Additional tests for MessageDigest with different providers

Reviewed-by: valeriep, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • 72db09b: 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
  • 3bbd233: 8270075: SplittableRandom extends AbstractSplittableGenerator
  • 381bd62: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • 82c256e: 8259499: Handling type arguments from outer classes for inner class in javadoc
  • e5db9a9: 8268620: InfiniteLoopException test may fail on x86 platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2021
@sisahoo
Create ReinitDigest.java
427bb38 
Provider name verification required.
@sisahoo
Copy link
Member Author

sisahoo commented Jul 15, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 15, 2021

Going to push as commit a32d2ee.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • 72db09b: 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
  • 3bbd233: 8270075: SplittableRandom extends AbstractSplittableGenerator
  • 381bd62: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • 82c256e: 8259499: Handling type arguments from outer classes for inner class in javadoc
  • e5db9a9: 8268620: InfiniteLoopException test may fail on x86 platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2021
@openjdk
Copy link

openjdk bot commented Jul 15, 2021

@sisahoo Pushed as commit a32d2ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradfordwetmore bradfordwetmore bradfordwetmore approved these changes

@valeriepeng valeriepeng valeriepeng approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated security security-dev@openjdk.java.net
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisahoo @bradfordwetmore @valeriepeng