Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267163: Rename anonymous loader tests to hidden loader tests #232

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 10, 2022

I backport this for parity with 17.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267163: Rename anonymous loader tests to hidden loader tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/232/head:pull/232
$ git checkout pull/232

Update a local copy of the PR:
$ git checkout pull/232
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 232

View PR using the GUI difftool:
$ git pr show -t 232

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/232.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 10, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5c21c0044104b52fcaf3f3a830ea6e219d504ada 8267163: Rename anonymous loader tests to hidden loader tests Mar 10, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 10, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 10, 2022

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8267163 branch from fabaf82 to 4381e70 Compare Mar 10, 2022
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267163: Rename anonymous loader tests to hidden loader tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 863631f: 8282225: GHA: Allow one concurrent run per PR only

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 11, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Mar 14, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 14, 2022

Going to push as commit d4d3348.
Since your change was applied there have been 14 commits pushed to the master branch:

  • c82e18f: 8281168: Micro-optimize VarForm.getMemberName for interpreter
  • 5edb982: 8279668: x86: AVX2 versions of vpxor should be asserted
  • bb8b3c2: 8279958: Provide configure hints for Alpine/apk package managers
  • 3c6aecd: 8276657: XSLT compiler tries to define a class with empty name
  • 79cce16: 8276825: hotspot/runtime/SelectionResolution test errors
  • 972dcde: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)
  • 535511a: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 3b53635: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • fb3ccbc: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun
  • e2fa3d3: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • ... and 4 more: https://git.openjdk.java.net/jdk17u-dev/compare/d5e4f03179cd34eb939ba63c9799db4ac7301650...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready rfr labels Mar 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 14, 2022

@GoeLin Pushed as commit d4d3348.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8267163 branch Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants