Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value #383

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 5, 2022

Backport of JDK-8282929
Clean except Copyright year update.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/383/head:pull/383
$ git checkout pull/383

Update a local copy of the PR:
$ git checkout pull/383
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 383

View PR using the GUI difftool:
$ git pr show -t 383

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/383.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c96085eaab1f6b21e084b94fcc619d090f0afc97 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 5, 2022
@TheRealMDoerr
Copy link
Contributor Author

/clean

@mlbridge
Copy link

mlbridge bot commented May 5, 2022

Webrevs

@openjdk openjdk bot added the clean label May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@TheRealMDoerr This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 5, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2022

Going to push as commit e5a71d7.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a839a36: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2022
@openjdk openjdk bot closed this May 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8282929_monetary_symbols branch May 6, 2022 15:47
@openjdk
Copy link

openjdk bot commented May 6, 2022

@TheRealMDoerr Pushed as commit e5a71d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant