Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273410: IR verification framework fails with "Should find method name in validIrRulesMap" #988

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 27, 2022

I backport this for parity with 17.0.7-oracle.

Requires follwo up 8275173


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273410: IR verification framework fails with "Should find method name in validIrRulesMap"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/988/head:pull/988
$ git checkout pull/988

Update a local copy of the PR:
$ git checkout pull/988
$ git pull https://git.openjdk.org/jdk17u-dev pull/988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 988

View PR using the GUI difftool:
$ git pr show -t 988

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/988.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport df125f680b6a4517109be80512a113064ca6281d 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" Dec 27, 2022
@openjdk
Copy link

openjdk bot commented Dec 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 27, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273410: IR verification framework fails with "Should find method name in validIrRulesMap"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 27, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 28, 2022

Pre-submit failure: CompensatedSums.java Known to be shaky, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Dec 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

Going to push as commit 032f007.
Since your change was applied there have been 5 commits pushed to the master branch:

  • bcdaebf: 8298027: Remove SCCS id's from awt jtreg tests
  • 70f235d: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • 11a53b7: Merge
  • 41c9d7d: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
  • 0ab310e: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2022
@openjdk openjdk bot closed this Dec 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@GoeLin Pushed as commit 032f007.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant