Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286855: javac error on invalid jar should only print filename #344

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 4, 2022

Hi all,

This pull request contains a backport of JDK-8286855, commit 1606d554 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 30 May 2022 and was reviewed by Jaikiran Pai and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286855: javac error on invalid jar should only print filename

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/344/head:pull/344
$ git checkout pull/344

Update a local copy of the PR:
$ git checkout pull/344
$ git pull https://git.openjdk.java.net/jdk17u pull/344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 344

View PR using the GUI difftool:
$ git pr show -t 344

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/344.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1606d5545b8daad840575b7cfd97b94fd8a3d41d 8286855: javac error on invalid jar should only print filename Jun 4, 2022
@openjdk
Copy link

openjdk bot commented Jun 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 4, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286855: javac error on invalid jar should only print filename

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

Going to push as commit 3472ab2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2022
@openjdk openjdk bot closed this Jun 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@RealCLanger Pushed as commit 3472ab2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant