8293834: Update CLDR data following tzdata 2022c update #26
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix.
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks. Flagged the bug with |
While this is still waiting for approval, I've added an update to the This change is also included in the 17u PR: openjdk/jdk17u#355 |
This now has @naotoj are you still ok with this, with the additional test changes? |
@gnu-andrew Looks OK to me, assuming those localized texts are retrieved from "Europe_Eastern" metazone texts of CLDR. |
They are, copied directly and then non-ASCII characters escaped (failed initially when I didn't do that: openjdk/jdk17u@f4d2dfa) The test passes on a patched build, but fails with an existing release (e.g. 17.0.4) as follows:
|
/integrate |
Going to push as commit e102312.
Your commit was automatically rebased without conflicts. |
@gnu-andrew Pushed as commit e102312. |
This adds the alias for
Europe/Kyiv
to the CLDR translation data, following the tzdata update which introduces this zone.This is unnecessary for trunk, as it will be added by an update to CLDR v42, but such updates are not backported.
Without patch (from openjdk/jdk#10012 (comment)):
With patch:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/26/head:pull/26
$ git checkout pull/26
Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk19u pull/26/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26
View PR using the GUI difftool:
$ git pr show -t 26
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/26.diff