-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292579: (tz) Update Timezone Data to 2022c #10012
Conversation
/issue add JDK-8292579 |
👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into |
@satoyoshiki The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
@satoyoshiki The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
The test failure seems to be irrelevant to this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@satoyoshiki This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @AlanBateman) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@satoyoshiki |
/sponsor |
Going to push as commit 98d85e6.
Your commit was automatically rebased without conflicts. |
@naotoj @satoyoshiki Pushed as commit 98d85e6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Should this not have included an update to the resource bundles - as with ad3be04 - so that |
That is something we've patched locally e.g. https://src.fedoraproject.org/rpms/java-11-openjdk/pull-request/163 and we have a test which fails without and passes with, though it does use |
Names are retrieved through aliases, so I think there is no need to add extra names in the COMPAT resource bundles.
CLDR incorporated the Kyiv/Kiev aliasing in their upcoming version 42, JDK does not have the alias yet, thus:
This will be fixed once we incorporate CLDR v42 into JDK repository. Since we don't backport CLDR, TZ backports should separately cherry-pick the changes in timezone.xml, such as:
|
Interesting, I remember changes like this causing failures in the past. Maybe they were introducing completely new zones. It looks good for the old
and similar for 11u & 17u with an updated tzdb. I guess we just need the CLDR change in a backport then. |
I've opened https://bugs.openjdk.org/browse/JDK-8293834 for the CLDR backport and will open a PR tomorrow for 19u. |
Please review this PR. The PR adopts the official tzdata2022c as it is.
It means the pre-1970s data merged in tzdata2022c doesn't exist.
All tests have been passed with no failures.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10012/head:pull/10012
$ git checkout pull/10012
Update a local copy of the PR:
$ git checkout pull/10012
$ git pull https://git.openjdk.org/jdk pull/10012/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10012
View PR using the GUI difftool:
$ git pr show -t 10012
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10012.diff