Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code #79

Conversation

olivergillespie
Copy link
Contributor

@olivergillespie olivergillespie commented May 16, 2023

Hi all,

This pull request contains a clean backport of commit 3f1927a7 from the openjdk/jdk repository.

The commit being backported was authored by Oli Gillespie on 4 May 2023 and was reviewed by Thomas Schatzl, Aleksey Shipilev and Albert Mingkun Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.org/jdk20u.git pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/79.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2023

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f1927a7f3a2914402a25335c47a5a8bdd5511a6 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 16, 2023

@olivergillespie This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 68fb0aa: 8307104: [AIX] VM crashes with UseRTMLocking on Power10
  • 2302454: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • 511ba72: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2023
@mlbridge
Copy link

mlbridge bot commented May 16, 2023

Webrevs

@olivergillespie
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@olivergillespie
Your change (at version 380e0ee) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 23, 2023

Going to push as commit 9997c71.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 68fb0aa: 8307104: [AIX] VM crashes with UseRTMLocking on Power10
  • 2302454: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • 511ba72: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2023
@openjdk openjdk bot closed this May 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@phohensee @olivergillespie Pushed as commit 9997c71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants