New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict symbol version map to global symbols #166
Conversation
Hi @nvinson, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user nvinson" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
Respectfully, I decline to sign the OCA. |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
ld.lld-17 fails to link when symbols such as ld.lld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZ21WB_HandshakeWalkStackE16TraceSelfClosure' failed: symbol not defined ld.lld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZ24WB_HandshakeReadMonitorsE19ReadMonitorsClosure' failed: symbol not defined ld.lld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZ26WB_AsyncHandshakeWalkStackE16TraceSelfClosure' failed: symbol not defined are listed in the version map. nm indicates these symbols are defined as local symbols. Remove them from the version map to resolve the issues. Fixes Gentoo bug 922147 ( https://bugs.gentoo.org/922147 ) Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
@nvinson Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
ld.lld-17 fails to link when symbols such as
are listed in the version map. nm indicates these symbols are defined as local symbols. Remove them from the version map to resolve the issues.
Progress
Error
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/166/head:pull/166
$ git checkout pull/166
Update a local copy of the PR:
$ git checkout pull/166
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/166/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 166
View PR using the GUI difftool:
$ git pr show -t 166
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/166.diff