Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict symbol version map to global symbols #166

Closed
wants to merge 1 commit into from

Conversation

nvinson
Copy link

@nvinson nvinson commented Jan 13, 2024

ld.lld-17 fails to link when symbols such as

ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
symbol '_ZTVZ21WB_HandshakeWalkStackE16TraceSelfClosure' failed:
symbol not defined

ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
symbol '_ZTVZ24WB_HandshakeReadMonitorsE19ReadMonitorsClosure'
failed: symbol not defined

ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
symbol '_ZTVZ26WB_AsyncHandshakeWalkStackE16TraceSelfClosure'
failed: symbol not defined

are listed in the version map. nm indicates these symbols are defined as local symbols. Remove them from the version map to resolve the issues.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/166/head:pull/166
$ git checkout pull/166

Update a local copy of the PR:
$ git checkout pull/166
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 166

View PR using the GUI difftool:
$ git pr show -t 166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/166.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 13, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2024

Hi @nvinson, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user nvinson" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2024

⚠️ @nvinson a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master cd166703a20c4ac51bc6478e8a0bb1275d9cb913
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@nvinson
Copy link
Author

nvinson commented Jan 15, 2024

Respectfully, I decline to sign the OCA.
I also do not claim any copyright ownership of the changes purposed.
Oracle is free to consider itself the sole owner of any copyrightable changes made by this PR.

@nvinson
Copy link
Author

nvinson commented Jan 15, 2024

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2024

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

ld.lld-17 fails to link when symbols such as

    ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
    symbol '_ZTVZ21WB_HandshakeWalkStackE16TraceSelfClosure' failed:
    symbol not defined

    ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
    symbol '_ZTVZ24WB_HandshakeReadMonitorsE19ReadMonitorsClosure'
    failed: symbol not defined

    ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
    symbol '_ZTVZ26WB_AsyncHandshakeWalkStackE16TraceSelfClosure'
    failed: symbol not defined

are listed in the version map. nm indicates these symbols are defined as
local symbols. Remove them from the version map to resolve the issues.

Fixes Gentoo bug 922147 ( https://bugs.gentoo.org/922147 )

Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@nvinson Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@nvinson nvinson closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
1 participant