Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318953: RISC-V: Small refactoring for MacroAssembler::test_bit #301

Closed

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Oct 30, 2023

Hi, this backport to make the test_bit assember function more simpler and to improve performance when the parameter (1UL << bit_pos) exceeds 32-bit range. This is a risc-v specific change. Backport is clean, risk is low.

Testing:

qemu 8.1.50:

  • Tier1 tests (release)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318953 needs maintainer approval

Issue

  • JDK-8318953: RISC-V: Small refactoring for MacroAssembler::test_bit (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/301/head:pull/301
$ git checkout pull/301

Update a local copy of the PR:
$ git checkout pull/301
$ git pull https://git.openjdk.org/jdk21u.git pull/301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 301

View PR using the GUI difftool:
$ git pr show -t 301

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/301.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 988e1dfe6ec9b5e77d2e8a78eb792a127c6fe907 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 30, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318953: RISC-V: Small refactoring for MacroAssembler::test_bit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • a96de29: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • 05deef8: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 599b30d: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • de57df4: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • c3c2b9f: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
  • ae5b92c: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • 3e46e29: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • 50e1a34: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • bbc5ad7: 8301341: LinkedTransferQueue does not respect timeout for poll()
  • 69adcc6: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@zifeihan
Copy link
Member Author

zifeihan commented Nov 2, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@zifeihan
Your change (at version 14fe1a6) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

Going to push as commit 6e21766.
Since your change was applied there have been 15 commits pushed to the master branch:

  • a96de29: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • 05deef8: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 599b30d: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • de57df4: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • c3c2b9f: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
  • ae5b92c: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • 3e46e29: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • 50e1a34: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • bbc5ad7: 8301341: LinkedTransferQueue does not respect timeout for poll()
  • 69adcc6: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2023
@openjdk openjdk bot closed this Nov 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@RealFYang @zifeihan Pushed as commit 6e21766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants