-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313781: Add regression tests for large page logging and user-facing error messages #358
8313781: Add regression tests for large page logging and user-facing error messages #358
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 99d260c.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 99d260c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8313781, commit abad0408 from the openjdk/jdk repository.
The commit being backported was authored by Thomas Stuefe on 27 Oct 2023 and was reviewed by Stefan Johansson and David Holmes.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/358/head:pull/358
$ git checkout pull/358
Update a local copy of the PR:
$ git checkout pull/358
$ git pull https://git.openjdk.org/jdk21u.git pull/358/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 358
View PR using the GUI difftool:
$ git pr show -t 358
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/358.diff
Webrev
Link to Webrev Comment